fixed bash wrapper error with Java version (as in MIXCR & mitools)#131
Open
amikelov wants to merge 1 commit intomikessh:masterfrom
Open
fixed bash wrapper error with Java version (as in MIXCR & mitools)#131amikelov wants to merge 1 commit intomikessh:masterfrom
amikelov wants to merge 1 commit intomikessh:masterfrom
Conversation
|
There's not much description on the actual issue but looking at the PR, this also fixes my issue which is that the shell script is incompatible with latest java 17 version (because version number for Java 8 was "1.8...." while for Java 17 is "17..."). Here's showing the issue: Using the existing version parser, one gets: This incorrect version parsing then prevents the shell script from starting vdjtools with the following bash error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.