Skip to content

Commit ae36f20

Browse files
committed
refactor: Improve ModuleUsersUI code structure and add validation
- Replace ModuleBaseForm with specific LdapConfigForm for better type safety - Add validation for user UI related POST data in UsersUIConf - Improve code readability with descriptive comments - Update code style according to PSR-12 standards
1 parent e11175a commit ae36f20

File tree

3 files changed

+17
-3
lines changed

3 files changed

+17
-3
lines changed

.DS_Store

0 Bytes
Binary file not shown.

App/Controllers/ModuleUsersUIController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121
namespace Modules\ModuleUsersUI\App\Controllers;
2222

2323
use MikoPBX\AdminCabinet\Providers\AssetProvider;
24-
use Modules\ModuleUsersUI\App\Forms\ModuleBaseForm;
24+
use Modules\ModuleUsersUI\App\Forms\LdapConfigForm;
2525
use Modules\ModuleUsersUI\Models\AccessGroups;
2626
use Modules\ModuleUsersUI\Models\LdapConfig;
2727
use Modules\ModuleUsersUI\Models\UsersCredentials;
@@ -82,7 +82,7 @@ public function indexAction(): void
8282
$this->view->members = $this->getTheListOfUsersForDisplayInTheFilter();
8383

8484
$ldapConfig = LdapConfig::findFirst();
85-
$this->view->ldapForm = new ModuleBaseForm($ldapConfig);
85+
$this->view->ldapForm = new LdapConfigForm($ldapConfig);
8686
$this->view->submitMode = null;
8787
}
8888
}

Lib/UsersUIConf.php

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,21 @@ public function onAfterExecuteRestAPIRoute(Micro $app): void
191191
if (!empty($response->result) and $response->result === true) {
192192
$userController = new UsersCredentialsController();
193193
$postData = $app->request->getPost();
194-
$userController->saveUserCredential($postData, $response);
194+
195+
// Check if any key in postData contains "module_users_ui_"
196+
$hasUserUIKeys = false;
197+
foreach ($postData as $key => $value) {
198+
if (strpos($key, 'module_users_ui_') !== false) {
199+
$hasUserUIKeys = true;
200+
break;
201+
}
202+
}
203+
204+
// Only save credentials if relevant keys are present
205+
if ($hasUserUIKeys) {
206+
$userController->saveUserCredential($postData, $response);
207+
}
208+
195209
$app->response->setContent(json_encode($response));
196210
}
197211
}

0 commit comments

Comments
 (0)