Fix CI and drop support for Node 12 #2
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikrostew
force-pushed
the
v4-implicit-injections
branch
2 times, most recently
from
d07d6e6 to
4615f0b
Compare
mikrostew
force-pushed
the
v4-implicit-injections
branch
from
4615f0b to
7139016
Compare
mikrostew
force-pushed
the
v4-implicit-injections
branch
from
7139016 to
439ed4e
Compare
mikrostew
changed the title
Owner
Author
|
this was a WIP PR to iterate on CI issues - closed to create a new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description TBD
Updated Node LTS Versions
This drops support for Node 12.x (which is EOL as of 2022/04/30), and adds support for Node 18+.
The tests now run against 14.x and 16.x.
I had to update
workerpoolto pull in the fix for Node16 mentioned in this issue.And I updated to a more recent version of Yarn.
Fixed the Legacy Mocha Tests
These have been failing for a while, with this error:
So I added that to
fastbootDependencies, which fixed the issue.Fixed the Ember-Try Tests
These have also been failing for a while, with this error:
I fixed that by preventing ember-try from running with
--no-lockfile(which it does by default, and was causing this dependency mismatch when running the tests).