Skip to content

Conversation

rohittiwari-dev
Copy link
Contributor

@rohittiwari-dev rohittiwari-dev commented Feb 20, 2024

Add : Typings for typescript support without changing original files
Test : Passes all 138 test cases with mocha

Note : only added support for using this package in typescript if required changes can be done each changes has been in [filename].d.ts

@rohittiwari-dev rohittiwari-dev changed the title [feat] adding typescript to the package #70 [feat] adding typescript to the package Feb 20, 2024
@mikuso
Copy link
Owner

mikuso commented Feb 25, 2024

Thanks for the contribution.

I've been hesitant to add typescript support so far (for reasons discussed in other threads), but I think I'd be happy to merge this since it doesn't try to solve the tricky problem of type safety with OCPP-specific calls.

Would you have time to label the private class members first? Any property or method beginning with a _ ought to be labelled as private. If you don't have time, let me know and I'll find time to do it at some point.

Thanks again.

@rohittiwari-dev
Copy link
Contributor Author

rohittiwari-dev commented Feb 25, 2024

thanks for the consideration, i will push the update today itself after adding private access identifier to all data-members which starts with _ ,

@rohittiwari-dev
Copy link
Contributor Author

Hi @mikuso, I have added labeling of access identifiers to all class member starts with '_' as required either private or protected as needed the server passes all tests with mocha. Please consider merging this.

Thanks once again, and thanks to Sunday national holiday in 'India' for the time.

@mikuso mikuso merged commit 8cffe3a into mikuso:master Feb 25, 2024
@mikuso
Copy link
Owner

mikuso commented Feb 25, 2024

Thanks for the contribution. Version 2.1.0 now published in npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants