Make variable filter test insensitive to order.#1132
Open
davidbau wants to merge 1 commit intomila-iqia:masterfrom
Open
Make variable filter test insensitive to order.#1132davidbau wants to merge 1 commit intomila-iqia:masterfrom
davidbau wants to merge 1 commit intomila-iqia:masterfrom
Conversation
Contributor
Author
|
This test fails for me because cg.variables seems to be coming back in an order different from the one expected by the test. Maybe theano changed the order? I am using Theano 0.9.0.dev2. |
Contributor
|
Are you running the test on GPU? I assume so, because Travis seems to be quite happy with your PR. Can you please share the error message with us, so that we know in which line the error happens? |
Contributor
Author
|
Yes, I have gpu enabled. Not the right way to run tests? Error message is just this: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test was previously sensitive to the order in which cg.variables is listed; now the test does not assume a particular ordering.