Skip to content

Rebased requires-io#1138

Merged
dmitriy-serdyuk merged 50 commits intomila-iqia:masterfrom
dmitriy-serdyuk:requires-io-fix
Aug 18, 2016
Merged

Rebased requires-io#1138
dmitriy-serdyuk merged 50 commits intomila-iqia:masterfrom
dmitriy-serdyuk:requires-io-fix

Conversation

@dmitriy-serdyuk
Copy link
Contributor

See #977

@dmitriy-serdyuk
Copy link
Contributor Author

That's funny. Conda is always a little bit behind => tests are always going to fail => we can never merge requires.io requests => dependencies never updated.

Requires-io shouldn't complain until pillow 3.4 is released
@dmitriy-serdyuk
Copy link
Contributor Author

According to this, directives I added makes requires.io think that pillow is up-to-date. I'm not sure if it will be trying to create pull requests.

Who knows how PR from requires works? I guess, I'll have to force push these changes to the requires-io-master branch.

@dmitriy-serdyuk
Copy link
Contributor Author

@dwf, could you take a look? @nouiz, do you have experience with requires, what do you think about these problems?

@dwf
Copy link
Contributor

dwf commented Aug 18, 2016

LGTM but I don't really know anything about requires.io.

@dmitriy-serdyuk
Copy link
Contributor Author

I'll merge it to be up-to-date and let's see what happens with #977.

@dmitriy-serdyuk dmitriy-serdyuk merged commit c3bf3a8 into mila-iqia:master Aug 18, 2016
@nouiz
Copy link
Contributor

nouiz commented Aug 19, 2016

I never used require.io. But I think it make PR to have your repo use the
up to date dependencies. So it mostly push you to make sure you support the
newer version of your dependencies. Not a bad idea.

I don't know why there is so much commit. If the repo have travis that test
PR, I guess that making one commit each time a dependencies is updated will
trigger the tests of all updates. So you will more clearly see which
updates your software don't support. Then it is up to you to merge the PR.
Making one PR for each update if you don't merge them isn't interresting,
so for me it make sence if they really work as I would have done it. Don't
forget, there is many speculation in what I wrote, maybe they just had a
bug...

On Thu, Aug 18, 2016 at 3:15 PM, dmitriy-serdyuk notifications@github.com
wrote:

Merged #1138 #1138.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1138 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AALC-5B4ctJD_kxDLwgbEUtIaqe8mfebks5qhK80gaJpZM4JnmOH
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants