feat: add native pframes OOM reproducer block - #1816
Open
AStaroverov wants to merge 3 commits into
Open
Conversation
🦋 Changeset detectedLatest commit: 09cc4dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1816 +/- ##
==========================================
- Coverage 54.56% 54.55% -0.01%
==========================================
Files 418 417 -1
Lines 21936 21932 -4
Branches 4913 4913
==========================================
- Hits 11970 11966 -4
Misses 8529 8529
Partials 1437 1437 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a developer block for reproducing memory exhaustion in the native pframes instance used by Platforma Desktop. Clicking Run memory stress joins two N-row inputs into N² rows and sorts the result; the UI requests only the table shape. Input size is configurable, and opening the block does not start the stress workload.
Includes the block packages, workspace registration, lockfile entries, and usage instructions. Completed attempts use a fresh axis domain to avoid cached results. Actual OOM behavior depends on available memory, pframes limits, and spilling.
Validation:
Greptile Summary
Adds a developer-only Platforma block that deliberately constructs and sorts a quadratic native pframes join, allowing Desktop developers to investigate memory-exhaustion behavior. Since the previous review, the table definition was extracted into a reusable builder and covered by a bounded native-driver regression test.
runIdafter each attempt so the next table uses a fresh axis domain rather than a cached result.Important touched terms
pframes-oomdeveloper block and registers all five packages in the workspace.createOomTableDefinitionso production and regression-test paths share the same query.runIdis incorporated into the shared axis domain to give completed attempts a fresh table identity.Confidence Score: 5/5
The PR appears safe to merge; the previously requested core regression coverage is present and no new actionable defects remain.
The manually resolved previous finding is fully addressed by a bounded native-driver test that verifies the quadratic result shape and fresh identity when
runIdchanges. The extraction into a shared table builder preserves runtime behavior, and the new test follows established driver setup and disposal patterns.Important Files Changed
Sequence Diagram
Reviews (2): Last reviewed commit: "test: cover pframes OOM join and cache i..." | Re-trigger Greptile