Change IncludeRetentionInfo parameter to exclude Evidence Locks outside of configured retention windows #163
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current way
-IncludeRetentionInfoperforms is that it just finds the oldest video and checks if it is older than or equal to the configured retention. That works fine, except when evidence locks are in use. If there is an evidence lock on video that is older than the configured retention, then the retention that is returned doesn't tell you if there is even any non-evidenced locked video in the retention window.This change checks to see if the camera has evidence locks. If it does, it uses a method to find the closest GOP to the configured retention time and uses that start time to check if
Related Issue
#160
Motivation and Context
This makes it so the actual retention mentioned in the output excludes evidence locked video that might exist after the configured retention. That way the user gets a more accurate value.
How Has This Been Tested?
Tested it against the current function to make sure nothing else was affected and to make sure the values were accurate.
Types of changes
Checklist: