Skip to content

Conversation

@Tarterman
Copy link
Contributor

Description

There has been a workaround in Get-VmsCameraReport for an issue where the streams folder didn't get populated when running $recorder.FillChildren($itemTypes, $itemFilters) (where Stream is one of the item types). The issue was resolved in the SDK in October 2021. Since current versions of MilestonePSTools cannot connect to 2021 versions, it is safe to remove the workaround.

Related Issue

#164

Motivation and Context

Eliminate an unnecessary foreach loop that was run against every camera.

How Has This Been Tested?

Ran a full Get-VmsCameraReport before the change and ran it again after the change and compared the results to make sure they were the same.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Eliminating unneeded code

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@github-actions
Copy link
Contributor

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b1df43a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant