Removed workaround for manually filling camera streams because of a bug in the SDK #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There has been a workaround in Get-VmsCameraReport for an issue where the streams folder didn't get populated when running
$recorder.FillChildren($itemTypes, $itemFilters)(where Stream is one of the item types). The issue was resolved in the SDK in October 2021. Since current versions of MilestonePSTools cannot connect to 2021 versions, it is safe to remove the workaround.Related Issue
#164
Motivation and Context
Eliminate an unnecessary foreach loop that was run against every camera.
How Has This Been Tested?
Ran a full Get-VmsCameraReport before the change and ran it again after the change and compared the results to make sure they were the same.
Types of changes
Checklist: