Closed
Conversation
Rupesh8844
reviewed
Oct 4, 2023
|
|
||
| public static Map<Integer,String> getColumnIndexToPropertyMap(Class<?> beanType) { | ||
| // Sanity checks | ||
| if (beanType == null) { |
There was a problem hiding this comment.
[pp] Instead of check with == we prefer Objects.isNull
if (Objects.isNull(beanType){ //logic }
Rupesh8844
reviewed
Oct 4, 2023
| package io.github.millij.bean; | ||
|
|
||
| import io.github.millij.poi.ss.model.annotations.SheetColumn; | ||
|
|
millij
requested changes
Oct 9, 2023
Owner
millij
left a comment
millij
left a comment
There was a problem hiding this comment.
Please use spaces instead of tabs.
millij
reviewed
Oct 11, 2023
Owner
There was a problem hiding this comment.
Replace the Tabs with Spaces in this file please.
Author
|
Modified the code and PR. Raised a new PR #53 (better readable) with same content. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced to specify the order of the columns at the annotation level.
User should specify the index (starts form 1) value of the column at annotations.