Skip to content

feat: Makes public the onItemDrop function of MLListItem #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat: Makes public the onItemDrop function of MLListItem #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a45bc31
feat: Makes public the onItemDrop function of MLListItem
Richard-Walton Dec 13, 2017
7bee121
Merge branch 'master' into feat/extensible-drop-behaviour
Richard-Walton Jan 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions dist/milo_ui.bundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1051,7 +1051,9 @@ var MLListItem = module.exports = milo.createComponentClass({
'dragenter': { subscriber: onDragHover, context: 'owner' },
'dragover': { subscriber: onDragHover, context: 'owner' },
'dragleave': { subscriber: onDragOut, context: 'owner' },
'drop': { subscriber: onItemDrop, context: 'owner' }
'drop': { context: 'owner', subscriber: function() {
this.onItemDrop.apply(this, arguments);
Copy link
Member

@jasoniangreen jasoniangreen Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shit code?

Copy link
Contributor Author

@Richard-Walton Richard-Walton Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol.

Copy link
Member

@jasoniangreen jasoniangreen Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

}}
},
allow: {
components: isComponentAllowed
Expand All @@ -1063,14 +1065,16 @@ var MLListItem = module.exports = milo.createComponentClass({
moveItem: MLListItem$moveItem,
removeItem: MLListItem$removeItem,
getMetaData: MLListItem$getMetaData,
isDropAllowed: MLListItem$isDropAllowed
isDropAllowed: MLListItem$isDropAllowed,
onItemDrop: MLListItem$onItemDrop
}
});


function MLListItem$init() {
MLListItem.super.init.apply(this, arguments);
this.on('childrenbound', onChildrenBound);

Copy link
Member

@jasoniangreen jasoniangreen Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random whitespace?

}


Expand Down Expand Up @@ -1113,7 +1117,7 @@ function isComponentAllowed() {
}


function onItemDrop(eventType, event) {
function MLListItem$onItemDrop(eventType, event) {
onDragOut.call(this);
var dt = new DragDrop(event);
var meta = dt.getComponentMeta();
Expand Down
9 changes: 6 additions & 3 deletions lib/components/ListItem.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@ var MLListItem = module.exports = milo.createComponentClass({
'dragenter': { subscriber: onDragHover, context: 'owner' },
'dragover': { subscriber: onDragHover, context: 'owner' },
'dragleave': { subscriber: onDragOut, context: 'owner' },
'drop': { subscriber: onItemDrop, context: 'owner' }
'drop': { context: 'owner', subscriber: function() {
this.onItemDrop.apply(this, arguments);
}}
},
allow: {
components: isComponentAllowed
Expand All @@ -31,7 +33,8 @@ var MLListItem = module.exports = milo.createComponentClass({
moveItem: MLListItem$moveItem,
removeItem: MLListItem$removeItem,
getMetaData: MLListItem$getMetaData,
isDropAllowed: MLListItem$isDropAllowed
isDropAllowed: MLListItem$isDropAllowed,
onItemDrop: MLListItem$onItemDrop
}
});

Expand Down Expand Up @@ -81,7 +84,7 @@ function isComponentAllowed() {
}


function onItemDrop(eventType, event) {
function MLListItem$onItemDrop(eventType, event) {
onDragOut.call(this);
var dt = new DragDrop(event);
var meta = dt.getComponentMeta();
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "milo-ui",
"version": "1.0.11",
"version": "1.0.12",
"description": "UI components and schema-based form generator for [milo.js](https://github.com/milojs/milo) framework",
"keywords": [
"framework",
Expand Down