Skip to content

Fix probe fail and exit while probe fail#237

Open
jaime0815 wants to merge 1 commit intomilvus-io:mainfrom
jaime0815:fix-probe-bw
Open

Fix probe fail and exit while probe fail#237
jaime0815 wants to merge 1 commit intomilvus-io:mainfrom
jaime0815:fix-probe-bw

Conversation

@jaime0815
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: jaime <yun.zhang@zilliz.com>
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jaime0815
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Comment on lines +144 to +147
if errCount != 0 {
fmt.Printf("probe failed, hit %d errors", errCount)
os.Exit(-1)
}
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may cause birdwatcher quit in normal mode quit
maybe we shall add a paramter for error handling here?

@mergify
Copy link
Copy Markdown

mergify bot commented Mar 31, 2025

@jaime0815 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco and removed dco-passed labels Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants