Skip to content

enhance: enrich show replica/resource-group display with session hostname#474

Open
chyezh wants to merge 2 commits intomilvus-io:mainfrom
chyezh:enhance_show_replica_rg
Open

enhance: enrich show replica/resource-group display with session hostname#474
chyezh wants to merge 2 commits intomilvus-io:mainfrom
chyezh:enhance_show_replica_rg

Conversation

@chyezh
Copy link
Copy Markdown
Contributor

@chyezh chyezh commented Mar 16, 2026

  • show replica: display RW/RO Query Nodes and RW/RO Streaming Nodes with hostname from session info, one node per line with tabwriter alignment
  • show resource-group: display full ResourceGroupConfig (request, limit, transfer_from, transfer_to, node_filter) and nodes with hostname
  • show wal-distribution: replace StreamingNode address with hostname
  • show wal-recovery-storage: replace StreamingNode address with hostname
  • All node displays show "NotFound" when session is missing

@sre-ci-robot sre-ci-robot requested a review from congqixia March 16, 2026 11:30
@sre-ci-robot
Copy link
Copy Markdown
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chyezh chyezh force-pushed the enhance_show_replica_rg branch from 8b95819 to 644e513 Compare March 16, 2026 11:30
@mergify mergify bot added the dco-passed label Mar 16, 2026
…name

- show replica: display RW/RO Query Nodes and RW/RO Streaming Nodes
  with hostname from session info, one node per line with tabwriter alignment
- show resource-group: display full ResourceGroupConfig (request, limit,
  transfer_from, transfer_to, node_filter) and nodes with hostname
- show wal-distribution: replace StreamingNode address with hostname
- show wal-recovery-storage: replace StreamingNode address with hostname
- All node displays show "NotFound" when session is missing

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the enhance_show_replica_rg branch from 644e513 to 2698566 Compare March 16, 2026 12:29
@mergify
Copy link
Copy Markdown

mergify bot commented Mar 17, 2026

@chyezh Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco and removed dco-passed labels Mar 17, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the enhance_show_replica_rg branch from ea4ffb0 to c78b452 Compare March 17, 2026 08:18
@mergify mergify bot added dco-passed and removed needs-dco labels Mar 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants