This repository was archived by the owner on Mar 21, 2025. It is now read-only.
custom attributes that can be used for altering a collection#867
Open
nustiueudinastea wants to merge 2 commits intomilvus-io:masterfrom
Open
custom attributes that can be used for altering a collection#867nustiueudinastea wants to merge 2 commits intomilvus-io:masterfrom
nustiueudinastea wants to merge 2 commits intomilvus-io:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nustiueudinastea The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Alex Giurgiu <alex@giurgiu.io>
nustiueudinastea
force-pushed
the
custom-collection-attributes
branch
from
dc9c589 to
21e1f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows for the altering (AlterCollection) of custom properties/attributes on a Milvus collection. The CreateCollection method already allows the setting of custom properties on the collection, but the AlterCollection did not. This PR fixes this discrepancy. This behaviour is also supported in the Python SDK.