Skip to content

Update proto#1727

Merged
sre-ci-robot merged 1 commit intomilvus-io:2.6from
yhmo:26
Dec 22, 2025
Merged

Update proto#1727
sre-ci-robot merged 1 commit intomilvus-io:2.6from
yhmo:26

Conversation

@yhmo
Copy link
Contributor

@yhmo yhmo commented Dec 22, 2025

PR Type

Enhancement


Description

  • Update milvus-proto submodule to latest commit

  • Incorporates protocol buffer changes from upstream


Diagram Walkthrough

flowchart LR
  oldCommit["44bb43c7e07b36fc6dcecba3b902c0612c0463d0"]
  newCommit["874a110cdf037515529944485534b5db43add044"]
  oldCommit -- "submodule update" --> newCommit
Loading

File Walkthrough

Relevant files
Dependencies
milvus-proto
Update milvus-proto submodule commit reference                     

sdk-core/src/main/milvus-proto

  • Updated submodule commit reference from
    44bb43c7e07b36fc6dcecba3b902c0612c0463d0 to
    874a110cdf037515529944485534b5db43add044
  • Pulls in latest protocol buffer definitions and changes from
    milvus-proto repository
+1/-1     

Signed-off-by: yhmo <yihua.mo@zilliz.com>
@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Dec 22, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@qodo-code-review
Copy link

PR Compliance Guide 🔍

Below is a summary of compliance checks for this PR:

Security Compliance
Supply chain update

Description: Updating the milvus-proto git submodule to a new commit introduces a supply-chain risk if
the upstream commit 874a110cdf037515529944485534b5db43add044 is not pinned to a
reviewed/trusted source (e.g., could include malicious proto changes that later affect
generated code or runtime behavior).
milvus-proto [1-1]

Referred Code
Subproject commit 874a110cdf037515529944485534b5db43add044
Ticket Compliance
🎫 No ticket provided
  • Create ticket/issue
Codebase Duplication Compliance
Codebase context is not defined

Follow the guide to enable codebase context checks.

Custom Compliance
🟢
Generic: Comprehensive Audit Trails

Objective: To create a detailed and reliable record of critical system actions for security analysis
and compliance.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Meaningful Naming and Self-Documenting Code

Objective: Ensure all identifiers clearly express their purpose and intent, making code
self-documenting

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Robust Error Handling and Edge Case Management

Objective: Ensure comprehensive error handling that provides meaningful context and graceful
degradation

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Error Handling

Objective: To prevent the leakage of sensitive system information through error messages while
providing sufficient detail for internal debugging.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Secure Logging Practices

Objective: To ensure logs are useful for debugging and auditing without exposing sensitive
information like PII, PHI, or cardholder data.

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Generic: Security-First Input Validation and Data Handling

Objective: Ensure all data inputs are validated, sanitized, and handled securely to prevent
vulnerabilities

Status: Passed

Learn more about managing compliance generic rules or creating your own custom rules

Compliance status legend 🟢 - Fully Compliant
🟡 - Partial Compliant
🔴 - Not Compliant
⚪ - Requires Further Human Verification
🏷️ - Compliance label

@qodo-code-review
Copy link

PR Code Suggestions ✨

No code suggestions found for the PR.

@yhmo yhmo added the lgtm label Dec 22, 2025
@sre-ci-robot sre-ci-robot merged commit 6da73f3 into milvus-io:2.6 Dec 22, 2025
6 checks passed
@yhmo yhmo deleted the 26 branch December 26, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants