Skip to content

Conversation

@yhmo
Copy link
Contributor

@yhmo yhmo commented Dec 26, 2025

  • Core invariant: this PR only prepares the SDK for release v2.6.11 — it is limited to version bumps, changelog/docs, test image updates, a proto submodule update, and release-notes-level behavioral/API additions; no breaking API surface removals are made and compatibility targets Milvus server 2.6.x+.
  • Simplifications/logic changes: the client pooling logic was adjusted to reuse existing MilvusClient objects (MilvusClientV2Pool / MilvusClientPool) to reduce allocation/initialization overhead — this replaces per-request client creation, a redundant cost given stable pooled connections; no protocol or serialization logic was removed.
  • Why no data loss or behavior regression: all changes are configuration/version updates and small fixes limited to client-side handling and metadata population:
    • QueryIterator fix restricts filter evaluation to correctly support RANDOM_SAMPLE — this changes control flow only in iterator query execution path and does not alter stored data.
    • insert() now accepts empty struct lists by skipping/handling empty nested collections — this prevents insertion errors but does not modify existing data semantics.
    • rpcDeadline is now honored for iterator operations (client-side timeout handling only).
    • max_length metadata for Array/Varchar fields is now populated (metadata correction only).
      These fixes adjust client-side validation/metadata and timeouts; they do not modify persisted records or on-disk formats.
  • Releases & artifacts: version strings updated (pom.xml, examples, README), docker/test image tags bumped (v2.6.6→v2.6.7), changelog added, and proto submodule pinned to commit 5b5ad72 to align generated APIs with the new client behaviors — these are release-alignment changes, not behavioral regressions.

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai
Copy link

coderabbitai bot commented Dec 26, 2025

Walkthrough

This PR bumps the SDK version from 2.6.10 to 2.6.11 across project metadata (pom.xml and examples/pom.xml) and README dependency snippets, adds a new CHANGELOG entry for 2.6.11 (four improvements, four bug fixes), updates Milvus Docker image tags from v2.6.6 to v2.6.7 in docker-compose.yml and test utilities, advances the milvus-proto submodule pointer, and increases a test workload in MilvusClientDockerTest (per-thread requests from 1000 to 10000). No public API signatures or exported declarations were changed.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • Update proto #1728: Updates the same sdk-core/src/main/milvus-proto submodule pointer to an earlier commit, related to the submodule advancement in this PR.

Suggested labels

lgtm, Review effort 2/5

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title "Prepare for v2.6.11" directly corresponds to the main objective of the pull request, which updates version numbers and changelog entries across multiple files from 2.6.10 to 2.6.11.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c7ee4f0 and 206a1c9.

📒 Files selected for processing (8)
  • CHANGELOG.md
  • README.md
  • docker-compose.yml
  • examples/pom.xml
  • pom.xml
  • sdk-core/src/main/milvus-proto
  • sdk-core/src/test/java/io/milvus/TestUtils.java
  • sdk-core/src/test/java/io/milvus/client/MilvusClientDockerTest.java
✅ Files skipped from review due to trivial changes (2)
  • sdk-core/src/main/milvus-proto
  • CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (2)
  • examples/pom.xml
  • docker-compose.yml
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md

41-41: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


43-43: Code block style
Expected: indented; Actual: fenced

(MD046, code-block-style)


47-47: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


49-49: Code block style
Expected: indented; Actual: fenced

(MD046, code-block-style)


66-66: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


68-68: Code block style
Expected: indented; Actual: fenced

(MD046, code-block-style)


72-72: Unordered list indentation
Expected: 0; Actual: 3

(MD007, ul-indent)


74-74: Code block style
Expected: indented; Actual: fenced

(MD046, code-block-style)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Deploy milvus server,build and test
  • GitHub Check: Build and test
  • GitHub Check: Summary
🔇 Additional comments (4)
sdk-core/src/test/java/io/milvus/client/MilvusClientDockerTest.java (1)

3157-3157: Verify the 10x increase in test workload.

The per-thread request count increased from 1,000 to 10,000, which means the total workload for this test increases from 20,000 to 200,000 requests (20 threads × 10,000 requests). This will significantly increase test execution time.

Can you confirm this change is intentional and provide context for why this increase is needed? If this is meant to provide more thorough stress testing of the client pool, consider whether this should be part of the regular test suite or moved to a separate performance/stress test suite to avoid impacting CI/CD pipeline execution times.

sdk-core/src/test/java/io/milvus/TestUtils.java (1)

14-14: LGTM!

The Milvus Docker image version update from v2.6.6 to v2.6.7 is appropriate for the v2.6.11 SDK release preparation.

pom.xml (1)

85-85: LGTM!

The version bump from 2.6.10 to 2.6.11 is consistent with the release preparation objective.

README.md (1)

25-25: LGTM!

All version references have been consistently updated from 2.6.10 to 2.6.11 across the compatibility table and all dependency examples (Maven, Gradle Groovy, and Gradle Kotlin formats).

Note: The markdown formatting issues flagged by static analysis (indentation and code block style) are pre-existing and not introduced by this PR.

Also applies to: 37-37, 44-44, 50-50, 62-62, 69-69, 75-75

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.40.3)
sdk-core/src/test/java/io/milvus/client/MilvusClientDockerTest.java

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify bot added the ci-passed label Dec 26, 2025
@yhmo yhmo added the lgtm label Dec 26, 2025
@sre-ci-robot sre-ci-robot merged commit 4ba9769 into milvus-io:master Dec 26, 2025
5 checks passed
@yhmo yhmo deleted the ma branch January 6, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants