feat: implement collection function management in gRPC API#496
Merged
shanghaikid merged 7 commits intomainfrom Jan 15, 2026
Merged
feat: implement collection function management in gRPC API#496shanghaikid merged 7 commits intomainfrom
shanghaikid merged 7 commits intomainfrom
Conversation
Contributor
shanghaikid
commented
Jan 15, 2026
shanghaikid
commented
- Added support for adding, altering, and dropping collection functions via gRPC.
- Introduced new request types: AddCollectionFunctionRequest, AlterCollectionFunctionRequest, and DropCollectionFunctionRequest.
- Updated Collection class to handle function operations with appropriate error handling.
- Enhanced schema definitions to include function-related fields and types.
- Updated test cases to validate the new function management features.
- Added support for adding, altering, and dropping collection functions via gRPC. - Introduced new request types: AddCollectionFunctionRequest, AlterCollectionFunctionRequest, and DropCollectionFunctionRequest. - Updated Collection class to handle function operations with appropriate error handling. - Enhanced schema definitions to include function-related fields and types. - Updated test cases to validate the new function management features. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
Signed-off-by: ryjiang <jiangruiyi@gmail.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shanghaikid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Changed service name from 'milvus-standalone' to 'standalone' in the test workflow configuration. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
- Replaced static YAML configuration creation with dynamic updates using `wget` and `awk` to ensure the OpenAI API key is correctly inserted. - Enhanced the script to check for existing OpenAI configuration and add missing fields as necessary. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
- Changed the environment variable name for the OpenAI API key to `MILVUS_OPENAI_API_KEY` for clarity. - Removed the dynamic YAML configuration generation and adjusted the docker-compose override to directly pass the OpenAI key as an environment variable. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #496 +/- ##
==========================================
- Coverage 97.18% 97.10% -0.08%
==========================================
Files 51 51
Lines 3517 3562 +45
Branches 961 976 +15
==========================================
+ Hits 3418 3459 +41
- Misses 94 98 +4
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
- Implemented tests to validate error handling for adding, altering, and dropping collection functions without required parameters. - Ensured that appropriate error messages are returned when schema or function names are missing. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.