Conversation
shanghaikid
commented
Jan 15, 2026
- feat: add http addCollectionField method
- feat: add alterCollectionProperties method and types
- feat: add alterCollectionFieldProperties method and types
- feat: add dropCollectionProperties method and type
- feat: add database management methods and types
- Implemented the addCollectionField method to allow adding new fields to collections. - Introduced HttpCollectionAddFieldReq and HttpCollectionAddFieldResponse types for request and response handling. - Updated tests to validate the functionality of adding a collection field. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
- Implemented the alterCollectionProperties method in the Collection class to modify collection properties. - Introduced HttpCollectionAlterPropertiesReq and HttpCollectionAlterPropertiesResponse types for request and response handling. - Updated tests to validate the functionality of altering collection properties. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
- Implemented the alterCollectionFieldProperties method in the Collection class to modify field properties of collections. - Introduced HttpCollectionAlterFieldPropertiesReq and HttpCollectionAlterFieldPropertiesResponse types for request and response handling. - Updated tests to validate the functionality of altering collection field properties. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
- Implemented the dropCollectionProperties method in the Collection class to remove specified properties from collections. - Introduced HttpCollectionDropPropertiesReq and HttpCollectionDropPropertiesResponse types for request and response handling. - Updated tests to validate the functionality of dropping collection properties. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
- Introduced Database mixin to extend HttpBaseClient with methods for altering and dropping database properties. - Added HttpDatabaseAlterPropertiesReq and HttpDatabaseAlterPropertiesResponse types for request and response handling. - Implemented alterDatabaseProperties and dropDatabaseProperties methods in the Database mixin. - Updated MilvusIndex to support new index property management methods. - Enhanced tests to validate the functionality of altering and dropping database and index properties. Signed-off-by: ryjiang <jiangruiyi@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shanghaikid The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @shanghaikid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the HTTP API client's capabilities by introducing a suite of new methods for managing various aspects of the Milvus system. It enables more granular control over collection fields, collection properties, database properties, and index properties, allowing users to programmatically modify and drop these elements. This enhancement improves the client's flexibility and completeness for schema evolution and system configuration. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces several new HTTP APIs for managing collections, databases, and indexes, along with their corresponding types and tests. The changes are well-structured, following the existing mixin pattern for extending client functionality. The new tests provide good coverage for the added features. I have one minor suggestion to improve code consistency and clarity.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #497 +/- ##
==========================================
+ Coverage 97.10% 97.16% +0.05%
==========================================
Files 51 52 +1
Lines 3562 3628 +66
Branches 976 978 +2
==========================================
+ Hits 3459 3525 +66
Misses 98 98
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|