fix: correct fullMethod for OperatePrivilegeV2 REST endpoints by sunby · Pull Request #48537 · milvus-io/milvus

sunby · 2026-03-26T06:24:40Z

Summary

REST handlers for /roles/grant_privilege_v2 and /roles/revoke_privilege_v2 pass V1 fullMethod OperatePrivilege instead of OperatePrivilegeV2 to wrapperProxy, causing Hook interceptors to reject the request as a denied API
Also fix routeToMethod metrics map entries for the same endpoints

The REST handlers for /roles/grant_privilege_v2 and /roles/revoke_privilege_v2 incorrectly pass the V1 fullMethod string "OperatePrivilege" instead of "OperatePrivilegeV2". This causes Hook interceptors to reject the request as a denied API. issue: milvus-io#48115 Signed-off-by: sunby <sunbingyi1992@gmail.com>

sre-ci-robot · 2026-03-26T06:24:54Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sunby
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

internal/distributed/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot · 2026-03-26T06:25:44Z

[ci-v2-notice]
Notice: New ci-v2 system is enabled for this PR.

To rerun ci-v2 checks, comment with:

/ci-rerun-code-check // for ci-v2/code-check
/ci-rerun-build // for ci-v2/build
/ci-rerun-build-all // for ci-v2/build-all (multi-arch builds)
/ci-rerun-buildenv // for ci-v2/build-env (build milvus-env builder images)
/ci-rerun-ut-integration // for ci-v2/ut-integration, will rerun ci-v2/build
/ci-rerun-ut-go // for ci-v2/ut-go, will rerun ci-v2/build
/ci-rerun-ut-cpp // for ci-v2/ut-cpp
/ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp, will rerun ci-v2/build
/ci-rerun-e2e-arm // for ci-v2/e2e-arm
/ci-rerun-e2e-default // for ci-v2/e2e-default
/ci-rerun-ciloop // for ci-v2/ciloop (build + unit tests in one pipeline)
/ci-rerun-gosdk // for ci-v2/go-sdk (Go SDK E2E tests, AMD)
/ci-rerun-gosdk-arm // for ci-v2/go-sdk-arm (Go SDK E2E tests, ARM)

If you have any questions or requests, please contact @zhikunyao.

codecov · 2026-03-26T07:41:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.81%. Comparing base (1c0302a) to head (442a826).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #48537       +/-   ##
===========================================
+ Coverage   74.95%   77.81%    +2.85%     
===========================================
  Files        1485     2100      +615     
  Lines      247232   349379   +102147     
===========================================
+ Hits       185323   271863    +86540     
- Misses      53589    69229    +15640     
+ Partials     8320     8287       -33

Components	Coverage Δ
Client	`79.25% <ø> (ø)`
Core	`84.01% <ø> (∅)`
Go	`75.79% <100.00%> (-0.04%)`	⬇️

Files with missing lines	Coverage Δ
...nternal/distributed/proxy/httpserver/handler_v2.go	`85.77% <100.00%> (ø)`

... and 672 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

sunby · 2026-03-26T09:04:03Z

/ci-rerun-integration-test

sunby · 2026-03-26T09:11:54Z

/ci-rerun-e2e-default
/ci-rerun-integration-test

sunby · 2026-03-26T09:34:07Z

/ci-rerun-integration-test

sunby · 2026-03-26T10:04:07Z