fix: pass response instead of status to CheckRPCCall to prevent nil deref#48539
fix: pass response instead of status to CheckRPCCall to prevent nil deref#48539sunby wants to merge 1 commit intomilvus-io:masterfrom
Conversation
…eref Signed-off-by: sunby <sunbingyi1992@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunby The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (33.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #48539 +/- ##
==========================================
- Coverage 77.64% 77.62% -0.02%
==========================================
Files 2112 2112
Lines 351505 351494 -11
==========================================
- Hits 272924 272850 -74
- Misses 70250 70307 +57
- Partials 8331 8337 +6
🚀 New features to boost your workflow:
|
|
/ci-rerun-e2e-arm |
|
/ci-rerun-e2e-arm |
|
/ci-rerun-e2e-default |
|
/ci-rerun-e2e-default |
|
/ci-rerun-go-sdk |
12 similar comments
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
|
/ci-rerun-go-sdk |
Pass whole response to merr.CheckRPCCall instead of resp.Status to prevent nil pointer dereference when broker returns (nil, err).
issue: #48538