enhance: unify stats file path model with caller-provided basePath#48548
Open
congqixia wants to merge 5 commits intomilvus-io:masterfrom
Open
enhance: unify stats file path model with caller-provided basePath#48548congqixia wants to merge 5 commits intomilvus-io:masterfrom
congqixia wants to merge 5 commits intomilvus-io:masterfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
sre-ci-robot
added
the
low-code-coverage
congqixia
force-pushed
the
enhance/loon/support_stats_basepath
branch
from
8a32fdc to
559ef4a
Compare
Move stats file (text_index, json_key_stats) path computation from C++ to Go. Go computes basePath based on storage version (V2: traditional top-level directories, V3: segment basePath/_stats/) and passes it to C++ via proto. C++ uses the basePath directly with no V2/V3 branching. Key changes: - Add stats_base_path to BuildIndexInfo proto (write path) - Add base_path to LoadTextIndexInfo/LoadJsonKeyIndexInfo proto (read path) - Add base_path to segcorepb TextIndexStats/JsonKeyStats (SegmentLoadInfo path) - TextMatchIndex::Upload() returns relative paths (consistent with JsonKeyStats) - JsonKeyStats::Load()/TextMatchIndex::Load() require basePath (Assert-checked) - Extract BuildTextIndexPrefix()/BuildJsonKeyStatsPrefix() to metautil to eliminate 5 duplicated format strings - ConvertToSegcoreSegmentLoadInfo() resolves V3 manifest stats with basePaths issue: milvus-io#48547 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia
force-pushed
the
enhance/loon/support_stats_basepath
branch
from
e8e38dd to
12d9ae8
Compare
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move stats file (text_index, json_key_stats) path computation from C++ to Go. Go computes basePath based on storage version (V2: traditional top-level directories, V3: segment basePath/_stats/) and passes it to C++ via proto. C++ uses the basePath directly with no V2/V3 branching.
Key changes:
issue: #48547