fix: add missing GEOMETRY case in DefaultValueChunkTranslator::value_size()#48556
Open
congqixia wants to merge 1 commit intomilvus-io:masterfrom
Open
fix: add missing GEOMETRY case in DefaultValueChunkTranslator::value_size()#48556congqixia wants to merge 1 commit intomilvus-io:masterfrom
congqixia wants to merge 1 commit intomilvus-io:masterfrom
Conversation
…size() Related to milvus-io#48555 GEOMETRY is a string-based data type but was not handled in the value_size() switch, causing DataTypeInvalid to be thrown when loading segments with default-valued GEOMETRY fields. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mergify
bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
Contributor
|
/lgtm |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #48556 +/- ##
===========================================
+ Coverage 45.42% 77.62% +32.19%
===========================================
Files 12 2112 +2100
Lines 2067 351495 +349428
===========================================
+ Hits 939 272844 +271905
- Misses 1076 70309 +69233
- Partials 52 8342 +8290
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #48555
GEOMETRY is a string-based data type but was not handled in the value_size() switch, causing DataTypeInvalid to be thrown when loading segments with default-valued GEOMETRY fields.