enhance: add SingleInstanceMetaClass to inherit from a generic type#2176
Open
csy1204 wants to merge 1 commit intomilvus-io:masterfrom
Open
enhance: add SingleInstanceMetaClass to inherit from a generic type#2176csy1204 wants to merge 1 commit intomilvus-io:masterfrom
csy1204 wants to merge 1 commit intomilvus-io:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: csy1204 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @csy1204! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
csy1204
changed the title
Signed-off-by: csy1204 <josang1204@gmail.com>
csy1204
force-pushed
the
feat/add-generic
branch
from
bf45f44 to
2b632c1
Compare
XuanYang-cn
added
the
PR | need to cherry-pick to 2.x
Contributor
|
@csy1204 Please fix the coding style |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
close #2175
Description
This PR can improve code readability on IDE. It gives clear type information.