fix: unpack _get_schema tuple return in _list_vector_indexes#3275
Merged
sre-ci-robot merged 3 commits intomilvus-io:masterfrom Feb 10, 2026
Merged
fix: unpack _get_schema tuple return in _list_vector_indexes#3275sre-ci-robot merged 3 commits intomilvus-io:masterfrom
sre-ci-robot merged 3 commits intomilvus-io:masterfrom
Conversation
_get_schema returns (schema_dict, schema_timestamp) tuple, but _list_vector_indexes was assigning the whole tuple to schema_dict, causing subsequent .get() calls to fail. Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3275 +/- ##
==========================================
+ Coverage 76.36% 76.46% +0.09%
==========================================
Files 63 63
Lines 13321 13321
==========================================
+ Hits 10173 10186 +13
+ Misses 3148 3135 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
Contributor
Author
|
/assign @XuanYang-cn |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: XuanYang-cn, zhuwenxing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
## Summary - `_get_schema` returns `(schema_dict, schema_timestamp)` tuple, but `_list_vector_indexes` was assigning the whole tuple to `schema_dict`, causing subsequent `.get()` calls to fail. - Fix by unpacking the tuple with `schema_dict, _ = ...`. ## Test plan - [x] Verify `_list_vector_indexes` works correctly after the fix --------- Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com> (cherry picked from commit 921e74b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Collaborator
|
✅ Backport Created (cc @XuanYang-cn) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_get_schemareturns(schema_dict, schema_timestamp)tuple, but_list_vector_indexeswas assigning the whole tuple toschema_dict, causing subsequent.get()calls to fail.schema_dict, _ = ....Test plan
_list_vector_indexesworks correctly after the fix