Skip to content

Conversation

@vahidkaargar
Copy link
Contributor

Add landline numbers validation for Iran and Germany

Copy link
Owner

@milwad-dev milwad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more countries?

@milwad-dev milwad-dev changed the title Validation for landline numbers [1.x] Validation for landline numbers Apr 17, 2025
@vahidkaargar
Copy link
Contributor Author

sure

@milwad-dev
Copy link
Owner

It is good to add this validation for all countries.

{
$rules = [
'landline_ir' => [new ValidLandlineNumber(Country::IRAN)],
'landline_de' => [new ValidLandlineNumber(Country::GERMANY)],
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure

Copy link
Owner

@milwad-dev milwad-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@milwad-dev milwad-dev merged commit fcb8857 into milwad-dev:1.x Apr 20, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants