-
-
Notifications
You must be signed in to change notification settings - Fork 46
[1.x] Validation for landline numbers #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
milwad-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add more countries?
|
sure |
|
It is good to add this validation for all countries. |
Support 18 countries for landline validations
Update documents for landline validation
| { | ||
| $rules = [ | ||
| 'landline_ir' => [new ValidLandlineNumber(Country::IRAN)], | ||
| 'landline_de' => [new ValidLandlineNumber(Country::GERMANY)], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure
milwad-dev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Add landline numbers validation for Iran and Germany