Skip to content

Add the parameter confirmed_height to retrieve_tx owner_api method #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
deevope wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add the parameter confirmed_height to retrieve_tx owner_api method #606

deevope wants to merge 2 commits into from

Conversation

@deevope
Copy link
Contributor

@deevope deevope commented Apr 15, 2021 •
edited
Loading

Improvement related to #595 and #362

  • Retrieve transaction in function of their confirmed block height*
  • add block height to the txs logs
  • wallet cmd argument to list txs in function of block height

I suggest to fix before the #607 issue before merging this PR. If this issue is fixed, this PR would need some more code, if not it can be merged.

@deevope deevope marked this pull request as ready for review April 27, 2021 17:09
@davidtavarez davidtavarez mentioned this pull request Jul 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@deevope