GitHub ci/cd fix #3815
Merged
GitHub ci/cd fix #3815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tromp
reviewed
Nov 22, 2025
| with: | ||
| files: | | ||
| target/release/grin-${{ github.ref_name }}-win-x86_64.zip | ||
| target/release/grin-${{ github.ref_name }}-win-x86_64-sha256sum.txt |
Contributor
There was a problem hiding this comment.
i don't see what changed on this line.
Contributor
Author
There was a problem hiding this comment.
No correct line ending existed at this file, so git provided LF ending, as I edited file at Github website. We can create.gitattributes file with * text=auto content, it will treat all files as text files and convert to OS's line ending on checkout and back to LF on commit automatically.
tromp
reviewed
Nov 22, 2025
| - name: Checkout | ||
| uses: actions/checkout@v3 | ||
| - name: Tests | ||
| run: cargo test --release --all |
Contributor
Author
There was a problem hiding this comment.
some Github nextline formatting I guess, CR LF
tromp
approved these changes
Nov 22, 2025
Contributor
tromp
left a comment
tromp
left a comment
There was a problem hiding this comment.
Looks fine, except for non-visible changes, which should be avoided.
tromp
approved these changes
Nov 22, 2025
wiesche89
added a commit
to wiesche89/grin
that referenced
this pull request
Nov 29, 2025
GitHub ci/cd fix (mimblewimble#3815)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
windows-2019towindows-2022.builtdependency to avoid link issue at old git2 lib: Windows build does not link with Advapi32.lib rust-lang/git2-rs#1142.