made makefile stabler for other OSs #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a few issues trying to compile the project on a non-Windows machine and decided to modernize the Makefile. This PR fixes the build errors and makes the workflow smoother for macOS and Linux users while keeping it compatible with Windows.
Key Changes:
Changed latexmk to use -pdf mode. The previous configuration ran in DVI mode, which caused ! Undefined control sequence errors with modern graphics packages.
The build was failing because the lmu-thesis-cover package expects a .charcount.txt file which didn't exist. I added a rule to automatically generate this file (using texcount if available, or defaulting to 0 if not) so the build succeeds out of the box.
Removed the hardcoded C:/Program Files/... path. The Makefile now detects the OS and uses the appropriate command to open the PDF.
Removed the obsolete thumbpdf dependency (modern viewers don't need it) and added clearer comments to the file.
Fixed aspell loop error (looped over each file inside the loop)