Chore: Resolve cspell issues by black7375 · Pull Request #151 · mincho-js/mincho

black7375 · 2025-02-11T16:59:06Z

Description

Eliminate annoying typos that appear as spelling errors.

Related Issue

Summary by CodeRabbit

Chores
- Updated editor configurations to recognize additional custom words, reducing false spelling alerts.
Refactor
- Standardized naming conventions to ensure consistent behavior during style processing.
Tests
- Enhanced error validation checks to improve the robustness of property handling.

This update brings internal improvements that enhance development reliability and ensure more accurate style validations.

Additional context

Checklist

changeset-bot · 2025-02-11T16:59:11Z

⚠️ No Changeset found

Latest commit: 38199bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions · 2025-02-11T16:59:21Z

Triggered from #151 by @black7375.

Checking if we can fast forward main (7899606) to resolve-cspell (38199bc).

Target branch (main):

commit 7899606780aa81a3e6efd5dacfe4184ba9713c7e (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Feb 10 01:33:02 2025 +0900

    Feat: Rules - `props()` runtime #131

Pull request (resolve-cspell):

commit 38199bc9145188f9a4dae4052be2382ce46b3929 (pull_request/resolve-cspell)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Wed Feb 12 01:54:59 2025 +0900

    Chore: Resolve cspell issues

It is possible to fast forward main (7899606) to resolve-cspell (38199bc). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to resolve-cspell.

black7375 · 2025-02-11T17:02:09Z

/fast-forward

github-actions · 2025-02-11T17:02:23Z

Triggered from #151 (comment) by @black7375.

Trying to fast forward main (7899606) to resolve-cspell (38199bc).

Target branch (main):

commit 7899606780aa81a3e6efd5dacfe4184ba9713c7e (HEAD -> main, origin/main, origin/HEAD)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Mon Feb 10 01:33:02 2025 +0900

    Feat: Rules - `props()` runtime #131

Pull request (resolve-cspell):

commit 38199bc9145188f9a4dae4052be2382ce46b3929 (pull_request/resolve-cspell)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Wed Feb 12 01:54:59 2025 +0900

    Chore: Resolve cspell issues

Fast forwarding main (7899606) to resolve-cspell (38199bc).

$ git push origin 38199bc9145188f9a4dae4052be2382ce46b3929:main
To https://github.com/mincho-js/mincho.git
   7899606..38199bc  38199bc9145188f9a4dae4052be2382ce46b3929 -> main

coderabbitai · 2025-02-11T17:03:15Z

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request applies configuration updates and minor code fixes. Three VS Code settings files now include additional custom words to improve spell checking, while a test file incorporates clarifying comments for error handling. In the transformation module, a function name was corrected from isSelectorskey to isSelectorsKey and its usage updated accordingly. Overall, these changes ensure consistency in naming and reduce false spell-check errors without altering core functionalities.

Changes

File(s)	Change Summary
`.../.vscode/settings.json` in css-additional-types, css, and transform-to-vanilla	Added new `cSpell.words` entries with custom words (e.g., "Resizer", "mincho", "nodenext", "fontface", "pretendard", "Unitless", "urange") to prevent false spelling errors.
`src/transform-keys/complex-selectors.ts` and `src/transform-object/index.ts` in transform-to-vanilla	Renamed function from `isSelectorskey` to `isSelectorsKey` and updated its import and usage accordingly.
`src/rules/types.ts` in css	Introduced error handling comments in test cases—highlighting issues like misnamed properties (`variantss` and `fonTsize`) to clarify expected values.

Sequence Diagram(s)

sequenceDiagram
    participant U as User
    participant TS as transformStyle
    participant IK as isSelectorsKey
    U->>TS: Call transformStyle(input)
    TS->>IK: Invoke isSelectorsKey(key)
    IK-->>TS: Return check result
    TS-->>U: Output transformed style

Poem

Oh, what a joyful hop today,
Configs sprout words in a brilliant array.
Bugs scurry off with a flick and twist,
Code now sings in each checklist.
I'm a bunny, leaping with delight—
Celebrating fixes from morning to night!

Warning

There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
[1/4] Resolving packages...
error Couldn't find any versions for "eslint-config-custom" that matches "workspace:^"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7899606 and 38199bc.

📒 Files selected for processing (6)

packages/css-additional-types/.vscode/settings.json (1 hunks)
packages/css/.vscode/settings.json (1 hunks)
packages/css/src/rules/types.ts (1 hunks)
packages/transform-to-vanilla/.vscode/settings.json (1 hunks)
packages/transform-to-vanilla/src/transform-keys/complex-selectors.ts (2 hunks)
packages/transform-to-vanilla/src/transform-object/index.ts (2 hunks)

✨ Finishing Touches

📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

Chore: Resolve cspell issues

38199bc

github-actions bot merged commit 38199bc into main Feb 11, 2025
7 checks passed

github-actions bot deleted the resolve-cspell branch February 11, 2025 17:02

coderabbitai bot mentioned this pull request Apr 22, 2025

Chore: Add cspell allow words #198

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Chore: Resolve cspell issues#151

Chore: Resolve cspell issues#151
github-actions[bot] merged 1 commit intomainfrom
resolve-cspell

black7375 commented Feb 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

changeset-bot bot commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

black7375 commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

Review failed

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

black7375 commented Feb 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issue

Summary by CodeRabbit

Additional context

Checklist

Uh oh!

changeset-bot bot commented Feb 11, 2025

⚠️ No Changeset found

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

black7375 commented Feb 11, 2025

Uh oh!

github-actions bot commented Feb 11, 2025

Uh oh!

Uh oh!

coderabbitai bot commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Sequence Diagram(s)

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

black7375 commented Feb 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)