Conversation
WalkthroughThe change updates the production build configuration in the custom Vite config. Specifically, the Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
yarn install v1.22.22 ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Triggered from #175 by @black7375. Checking if we can fast forward Target branch ( commit a963dc1854e0b4278e01c7008ec8187add2eecad (HEAD -> main, tag: @mincho-js/react@0.0.3, tag: @mincho-js/integration@0.0.3, tag: @mincho-js/esbuild@0.0.3, tag: @mincho-js/babel@0.0.3, origin/main)
Author: sangkukbae <sangkukbae@gmail.com>
Date: Thu Apr 3 02:51:53 2025 +0900
feat: Co-location using babelPull request ( commit 871e38ae97311961dfd3adc543279459a70c5f68 (pull_request/vite-option)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sat Apr 5 23:52:25 2025 +0900
Chore: Disable minify optionIt is possible to fast forward |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
configs/vite-config-custom/index.js (1)
117-127: Consider making minification configurable.Now that both development and production environments have minification disabled, you might want to consider making this configurable through an environment variable. This would allow you to easily toggle minification on/off without code changes when needed for performance vs. debugging.
if (ViteEnv.isProd()) { configs.add({ build: { sourcemap: false, - minify: false + minify: process.env.ENABLE_MINIFY === 'true' ? 'terser' : false } }); }Also applies to: 129-136
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
configs/vite-config-custom/index.js(1 hunks)
🔇 Additional comments (2)
configs/vite-config-custom/index.js (2)
129-135: Approve change to disable minification in production builds.This change aligns with the PR objective of improving debuggability by disabling the minification option. With minification turned off, debugging production issues will be more straightforward as the code will maintain its original structure and variable names.
While this will increase bundle size, the tradeoff for improved debugging capability is reasonable, especially if referenced issue #60 involves troubleshooting production problems.
129-135:Details
❓ Verification inconclusive
Verify impact on bundle size.
While disabling minification improves debuggability, it significantly increases bundle size, which may impact performance. Consider measuring the size difference to understand the trade-off and documenting this decision.
🏁 Script executed:
#!/bin/bash # Compare bundle sizes with and without minification # Note: This is a demonstration script that would need to be run separately in production and development environments echo "Checking current project size structure:" find dist -type f -name "*.js" -o -name "*.mjs" -o -name "*.cjs" | xargs ls -la | sort -k5 -nr | head -5Length of output: 563
Ensure accurate bundle size evaluation before merging changes.
- The output of the verification script indicates that the expected production build directory (
dist) was not found. This suggests that either the production build hasn’t been generated yet or the output directory is configured differently.- Please confirm that the production build produces the output in the expected directory. If a different directory is used (or if the build hasn’t been run), update the script accordingly and re-measure the bundle sizes.
- Once the correct bundle files are identified, compare the size differences with minification disabled to assess any performance impact and document the findings.
|
/fast-forward |
|
Triggered from #175 (comment) by @black7375. Trying to fast forward Target branch ( commit a963dc1854e0b4278e01c7008ec8187add2eecad (HEAD -> main, tag: @mincho-js/react@0.0.3, tag: @mincho-js/integration@0.0.3, tag: @mincho-js/esbuild@0.0.3, tag: @mincho-js/babel@0.0.3, origin/main, origin/HEAD)
Author: sangkukbae <sangkukbae@gmail.com>
Date: Thu Apr 3 02:51:53 2025 +0900
feat: Co-location using babelPull request ( commit 871e38ae97311961dfd3adc543279459a70c5f68 (pull_request/vite-option)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sat Apr 5 23:52:25 2025 +0900
Chore: Disable minify optionFast forwarding $ git push origin 871e38ae97311961dfd3adc543279459a70c5f68:main
To https://github.com/mincho-js/mincho.git
a963dc1..871e38a 871e38ae97311961dfd3adc543279459a70c5f68 -> main |
1 participant
Description
It's a library package, and minifies it to make debugging easier.
Related Issue
@mincho-js/csspackage #60Summary by CodeRabbit
Additional context
Checklist