Chore: Update yarn to 4.9.1 and refactor CI#190
Conversation
|
|
Warning Rate limit exceeded@black7375 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 6 minutes and 27 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (6)
WalkthroughThis set of changes updates several configuration files related to Yarn and GitHub Actions workflows. The Yarn version is upgraded from 4.6.0 to 4.9.1, and cache paths are extended to improve caching efficiency. The Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Node Setup Action
participant Yarn
GitHub Actions->>Node Setup Action: Start setup
Node Setup Action->>Yarn: Set winLinkType symlinks
Node Setup Action->>Yarn: Install dependencies
Node Setup Action->>Yarn: Cache .yarn/cache, .yarn/unplugged, etc.
sequenceDiagram
participant GitHub Actions
participant PR Branch Fetch Step
participant Checkout Step
GitHub Actions->>PR Branch Fetch Step: Get PR number from event context
PR Branch Fetch Step->>GitHub API: Fetch PR branch name
PR Branch Fetch Step-->>GitHub Actions: Output branch name
GitHub Actions->>Checkout Step: Checkout using fetched branch name
Possibly related PRs
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Triggered from #190 by @black7375. Checking if we can fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit 5ade09804e97f83ac34526448d5200b8db37ceee (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:22:23 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIIt is possible to fast forward |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🔭 Outside diff range comments (1)
.github/workflows/rebase.yml (1)
58-62:⚠️ Potential issueUndefined
MAIN_HEADvariable breaks rebase check
The script compares the current HEAD to$MAIN_HEAD, butMAIN_HEADis never initialized. This renders the “already up to date” logic ineffective. Capture the base-branch HEAD immediately after the checkout. For example:- PR_HEAD=$(git rev-parse HEAD) + MAIN_HEAD=$(git rev-parse HEAD) # capture base branch HEAD + PR_HEAD=$(git rev-parse HEAD)Ensure
MAIN_HEADis set right after the initialactions/checkoutstep.
🧹 Nitpick comments (3)
.github/actions/node-setup/action.yml (1)
25-30: Expand Yarn cache paths for optimal CI performance
Adding.yarn/unplugged,.yarn/build-state.yml, and.yarn/install-state.gzwill reduce install times by preserving more of Yarn’s state. Consider also caching.yarn/patchesand.yarn/pluginsto further speed up your workflow..github/workflows/rebase.yml (1)
31-43: Referencesteps.check_comment.outputs.MATCHin conditional steps
All the conditional steps now correctly use the step output syntax (steps.check_comment.outputs.MATCH). To DRY up the workflow, you could lift this to a job-levelifso you don’t repeat the same condition on each step..github/workflows/fast-forward.yml (1)
33-33: Guard steps with theMATCHoutput
Theif: steps.check_comment.outputs.MATCH == 'true'clauses ensure the fast-forward and branch-check steps only run when/fast-forwardis detected. As an enhancement, consider moving this to a job-levelifto reduce duplication.Also applies to: 45-45
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
.yarn/releases/yarn-4.6.0.cjsis excluded by!**/.yarn/**.yarn/releases/yarn-4.9.1.cjsis excluded by!**/.yarn/**
📒 Files selected for processing (5)
.github/actions/node-setup/action.yml(1 hunks).github/workflows/fast-forward.yml(3 hunks).github/workflows/rebase.yml(1 hunks).yarnrc.yml(1 hunks)package.json(1 hunks)
🔇 Additional comments (6)
package.json (1)
5-5: Align Yarn version with project configuration
ThepackageManagerfield is correctly updated toyarn@4.9.1, matching the version in.yarnrc.yml. This ensures consistency across local and CI environments..yarnrc.yml (1)
19-22:Details
✅ Verification successful
Configure PNPM store and bump Yarn path
The newpnpmStoreFolderdirective at line 19 guides the PNPM store location, and the updatedyarnPathat line 21 correctly points to the Yarn v4.9.1 release. Ensure that.yarn/releases/yarn-4.9.1.cjsis committed to the repo.Run this script to verify the Yarn release file is present:
🏁 Script executed:
#!/bin/bash if [ ! -f .yarn/releases/yarn-4.9.1.cjs ]; then echo "Error: .yarn/releases/yarn-4.9.1.cjs not found" exit 1 fi echo "✅ Yarn release file exists."Length of output: 111
Configure PNPM store and bump Yarn path
pnpmStoreFolderis correctly set to.cache/.store.yarnPathpoints to.yarn/releases/yarn-4.9.1.cjs, and the file exists in the repo.All changes look good—approving.
.github/actions/node-setup/action.yml (1)
36-36: Enable Windows symlink support for Yarn
Theyarn config set winLinkType symlinkscommand ensures proper symlink behavior on Windows runners. Leaving it unguarded is fine since it’s a no-op on non-Windows hosts..github/workflows/rebase.yml (1)
25-28: Switch to using$GITHUB_OUTPUTfor step outputs
Updating toecho "MATCH=…" >> $GITHUB_OUTPUTaligns with the deprecation notice forsave-state/set-outputand correctly setssteps.check_comment.outputs.MATCH..github/workflows/fast-forward.yml (2)
27-30: Use$GITHUB_OUTPUTto export the match result
Switching from the deprecated$GITHUB_ENVto$GITHUB_OUTPUTaligns with the latest Actions recommendations and correctly publishesMATCHas a step output.
116-125: Dynamically fetch and checkout the PR branch for release
Retrieving the PR branch via the GitHub API and usingref: ${{ steps.get_pr_branch.outputs.branch }}now correctly targets the contributor’s branch instead of defaulting tomain.Also applies to: 130-131
|
Triggered from #190 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit 5ade09804e97f83ac34526448d5200b8db37ceee (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:22:23 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIcurl: (3) bad range in URL position 74: |
|
Triggered from #190 by @black7375. Checking if we can fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit e81d9c8423a75c52fadc8be19c05df611686d9e4 (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:28:22 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIIt is possible to fast forward |
|
Triggered from #190 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit e81d9c8423a75c52fadc8be19c05df611686d9e4 (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:28:22 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIcurl: (3) bad range in URL position 74: |
1 similar comment
|
Triggered from #190 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit e81d9c8423a75c52fadc8be19c05df611686d9e4 (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:28:22 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIcurl: (3) bad range in URL position 74: |
|
Triggered from #190 by @black7375. Checking if we can fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit 2d679a4c7bf11c0c1ce53ed9ad30397a3788c2b0 (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:43:05 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIIt is possible to fast forward |
|
Triggered from #190 (comment) by @coderabbitai[bot]. Trying to fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit 2d679a4c7bf11c0c1ce53ed9ad30397a3788c2b0 (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:43:05 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIcurl: (3) bad range in URL position 74: |
|
Triggered from #190 by @black7375. Checking if we can fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit abaf21a820070455e136ebcf3a48883e09ad2449 (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:46:37 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIIt is possible to fast forward |
|
/fast-forward |
|
Triggered from #190 (comment) by @black7375. Trying to fast forward Target branch ( commit 93841d4d6fb315623964005a1ec2c51bd4a54fba (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:12:41 2025 +0900
Chore: Rebase ActionPull request ( commit abaf21a820070455e136ebcf3a48883e09ad2449 (pull_request/yarn-ver)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Sun Apr 20 07:46:37 2025 +0900
Chore: Update yarn to 4.9.1 and refactor CIFast forwarding $ git push origin abaf21a820070455e136ebcf3a48883e09ad2449:main
To https://github.com/mincho-js/mincho.git
93841d4..abaf21a abaf21a820070455e136ebcf3a48883e09ad2449 -> main |
1 participant
Description
Related Issue
Summary by CodeRabbit
Additional context
Checklist