Fix: Separate release and fast-forward workflows #118#196
Fix: Separate release and fast-forward workflows #118#196github-actions[bot] merged 1 commit intomainfrom
Conversation
|
|
Caution Review failedThe pull request is closed. WalkthroughThis update restructures the GitHub Actions workflows by separating the release process from the fast-forward process. The Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant GitHub Actions
participant Fast-Forward Workflow
participant Release Workflow
User->>GitHub Actions: Comment "/fast-forward" on PR
GitHub Actions->>Fast-Forward Workflow: Trigger workflow
Fast-Forward Workflow->>GitHub Actions: Run fast-forward action
User->>GitHub Actions: Push to main branch
GitHub Actions->>Release Workflow: Trigger workflow
Release Workflow->>GitHub Actions: Checkout, setup, run changesets, publish
Possibly related PRs
Suggested labels
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Triggered from #196 by @black7375. Checking if we can fast forward Target branch ( commit 98a9c9335f84407717cd5fd7d62ce6c6070af284 (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Wed Apr 23 02:42:15 2025 +0900
Fix: CSS - Work comma selector with nested selectorsPull request ( commit 01ad0e014496d382442c9c5a814f1812caf18537 (pull_request/separated-workflow)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Wed Apr 23 02:55:22 2025 +0900
Fix: Separate release and fast-forward workflows #118It is possible to fast forward |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (4)
.github/workflows/fast-forward.yml (2)
7-9: Unify comment-filtering logic
You’re using both a job-levelif:and a step with regex to gate execution. Consider consolidating into one location (either the job-levelifor thecheck_commentstep) to reduce duplication.
29-38: Add concurrency to avoid overlapping runs
To prevent multiple fast‑forward jobs from queuing on the same PR, you can introduce aconcurrencykey under this job. For example:jobs: fast-forward: runs-on: ubuntu-latest + concurrency: + group: fast-forward-${{ github.event.issue.number }} + cancel-in-progress: true.github/workflows/release.yml (2)
12-18: Restrict permissions to principle of least privilege
You’ve granted broad write scopes (issues, pull-requests, statuses). Verify ifissues: writeis needed—changesets usually only requirecontents,packages, andstatuses.
42-50: Consider uploading logs as artifacts on failure
Printing logs to console can be noisy. You might useactions/upload-artifactto collect the npm logs for post-mortem. For example:- - name: Show log on failure + - name: Upload npm logs on failure if: failure() - run: | - cd /home/runner/.npm/_logs/ || exit - for file in *; do - echo "=== File: $file ===" - cat "$file" - echo -e "\n\n" - done + uses: actions/upload-artifact@v3 + with: + name: npm-logs + path: /home/runner/.npm/_logs
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/fast-forward.yml(1 hunks).github/workflows/release.yml(1 hunks)
🔇 Additional comments (6)
.github/workflows/fast-forward.yml (2)
1-4: Approve workflow rename and trigger
Renaming to “fast-forward” and restricting the event to pull request comments containing/fast-forwardis clear and focused.
18-27: Boundary-safe regex check is solid
The regex correctly matches/fast-forwardas a standalone token and prevents false positives. Great use of word‑boundary logic..github/workflows/release.yml (4)
1-5: Approve release workflow trigger
Triggering this workflow onpushtomaincleanly decouples release automation from fast-forward logic.
20-24: Checkout step with full history is correct
Usingfetch-depth: 0ensures tags and full history are available for versioning. This aligns with best practices for releases.
25-27: Verify custom node-setup action
Ensure that./.github/actions/node-setupexists and properly installs/caches the desired Node versions.
28-36: Validate changesets commands
Confirm that youryarn run publishandyarn run changeset:versionscripts are defined inpackage.json. Mismatches here will cause silent failures in versioning or publishing.
black7375
force-pushed
the
separated-workflow
branch
from
01ad0e0 to
b89c106
Compare
|
Triggered from #196 by @black7375. Checking if we can fast forward Target branch ( commit 98a9c9335f84407717cd5fd7d62ce6c6070af284 (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Wed Apr 23 02:42:15 2025 +0900
Fix: CSS - Work comma selector with nested selectorsPull request ( commit b89c1066281e6547972d25dfdf6591bcdf7e9df4 (pull_request/separated-workflow)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Wed Apr 23 03:03:02 2025 +0900
Fix: Separate release and fast-forward workflows #118It is possible to fast forward |
|
/fast-forward |
|
Triggered from #196 (comment) by @black7375. Trying to fast forward Target branch ( commit 98a9c9335f84407717cd5fd7d62ce6c6070af284 (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Wed Apr 23 02:42:15 2025 +0900
Fix: CSS - Work comma selector with nested selectorsPull request ( commit b89c1066281e6547972d25dfdf6591bcdf7e9df4 (pull_request/separated-workflow)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Wed Apr 23 03:03:02 2025 +0900
Fix: Separate release and fast-forward workflows #118Fast forwarding $ git push origin b89c1066281e6547972d25dfdf6591bcdf7e9df4:main
To https://github.com/mincho-js/mincho.git
98a9c93..b89c106 b89c1066281e6547972d25dfdf6591bcdf7e9df4 -> main |
1 participant
Description
Related Issue
Summary by CodeRabbit
Additional context
Checklist