Skip to content

Chore: use tsgo in vscode#264

Merged
github-actions[bot] merged 1 commit intomainfrom
ts-go
Oct 27, 2025
Merged

Chore: use tsgo in vscode#264
github-actions[bot] merged 1 commit intomainfrom
ts-go

Conversation

@black7375
Copy link
Contributor

@black7375 black7375 commented Oct 26, 2025

Description

Make faster vscode lsp.

Related Issue

Summary by CodeRabbit

  • Chores
    • Updated development environment configuration to support experimental TypeScript performance enhancements.
    • Added TypeScript native preview tool to recommended developer extensions for improved development experience.

Additional context

Checklist

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2025

⚠️ No Changeset found

Latest commit: 7488b27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai
Copy link

coderabbitai bot commented Oct 26, 2025

Walkthrough

VS Code configuration updates enable experimental TypeScript TSGO feature and add native preview extension recommendation. TypeScript SDK path updated with trailing slash; alternative native-preview path added as comment for future reference.

Changes

Cohort / File(s) Summary
VS Code Extension Recommendations
\\.vscode/extensions.json
Added "TypeScriptTeam.native-preview" to recommended extensions array alongside existing vitest.explorer entry
VS Code TypeScript Settings
\\.vscode/settings.json
Enabled experimental TSGO feature (typescript.experimental.useTsgo: true); updated TypeScript SDK path from ./node_modules/typescript/lib to ./node_modules/typescript/lib/ (trailing slash); added commented alternative path for native-preview SDK

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Configuration-only changes with no logic modifications
  • Extension addition is low-risk
  • SDK path adjustment is straightforward; verify trailing slash doesn't break resolution in the project's environment

Poem

🐰 A rabbit hops through settings files with glee,
Adding previews native, experimental and free,
The TypeScript path now has a trailing slash dance,
TSGO experiments get their chance,
Extensions recommended, the workflow's enhanced! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning, 1 inconclusive)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
Description Check ❓ Inconclusive While the pull request description follows the template structure with all required sections present (Description, Related Issue, Additional context, and Checklist), the content itself is notably vague and incomplete. The Description section only contains "Make faster vscode lsp." which is an extremely brief statement that lacks detail about what TSGO is, why it's being enabled, why the TypeScript SDK path is changing, or why the native-preview extension is being added. The Related Issue, Additional context, and Checklist sections are all empty, and no additional context is provided to help reviewers understand the full scope and implications of the changes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title "Chore: use tsgo in vscode" directly aligns with the primary objective of the changeset. The changes involve enabling the experimental TSGO feature in VSCode settings and adding the native-preview extension recommendation, with the stated goal of making VSCode LSP faster. The title is concise, specific, and clearly communicates the main change that a teammate would understand when scanning PR history.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ts-go

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a987d8e and 7488b27.

📒 Files selected for processing (2)
  • .vscode/extensions.json (1 hunks)
  • .vscode/settings.json (1 hunks)
🔇 Additional comments (3)
.vscode/extensions.json (1)

10-11: Recommend clarifying the intent of both extensions.

The native-preview extension is being recommended alongside vitest.explorer. Given that native-preview is commented out in settings.json (line 5 of .vscode/settings.json), it's unclear whether this extension recommendation is necessary for the TSGO workflow or if it's for future use.

Does the native-preview extension need to be actively recommended at this point, or should the recommendation be deferred until native-preview becomes the primary TypeScript SDK path? Please clarify the intended developer experience.

.vscode/settings.json (2)

3-3: Enabling experimental TSGO feature for LSP performance.

The typescript.experimental.useTsgo flag is enabled to accelerate VS Code's TypeScript language server. This aligns with the PR objective to "make faster vscode lsp."

Please confirm:

  1. This experimental feature is stable enough for team development.
  2. All team members are using compatible VSCode/TypeScript versions that support TSGO.
  3. There are no known issues or regressions with this feature in the current TypeScript version.

5-6: No issues found. The TypeScript SDK path configuration is correct.

The trailing slash is not required for VS Code's typescript.tsdk setting—both ./node_modules/typescript/lib and ./node_modules/typescript/lib/ are valid and will resolve correctly. The commented-out line on line 5 is simply a disabled alternative; the developer chose to use the stable TypeScript implementation (v5.9.3) rather than @typescript/native-preview, which is an experimental preview of the native Go-based TypeScript compiler. This is a reasonable and safe choice.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

Triggered from #264 by @​black7375.

Checking if we can fast forward main (a987d8e) to ts-go (7488b27).

Target branch (main):

commit a987d8e91f8337942e3faff755087b81e854590f (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Fri Sep 19 00:00:00 2025 +0900

    fix: typescript settings

Pull request (ts-go):

commit 7488b27101a6a646dfe0136966e76df4672a74d3 (pull_request/ts-go)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Sep 20 00:00:00 2025 +0900

    Chore: use tsgo in vscode

It is possible to fast forward main (a987d8e) to ts-go (7488b27). If you have write access to the target repository, you can add a comment with /fast-forward to fast forward main to ts-go.

@black7375
Copy link
Contributor Author

/fast-forward

@github-actions
Copy link
Contributor

Triggered from #264 (comment) by @​black7375.

Trying to fast forward main (a987d8e) to ts-go (7488b27).

Target branch (main):

commit a987d8e91f8337942e3faff755087b81e854590f (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Fri Sep 19 00:00:00 2025 +0900

    fix: typescript settings

Pull request (ts-go):

commit 7488b27101a6a646dfe0136966e76df4672a74d3 (pull_request/ts-go)
Author: alstjr7375 <alstjr7375@daum.net>
Date:   Sat Sep 20 00:00:00 2025 +0900

    Chore: use tsgo in vscode

Fast forwarding main (a987d8e) to ts-go (7488b27).

$ git push origin 7488b27101a6a646dfe0136966e76df4672a74d3:main
To https://github.com/mincho-js/mincho.git
   a987d8e..7488b27  7488b27101a6a646dfe0136966e76df4672a74d3 -> main

@github-actions github-actions bot merged commit 7488b27 into main Oct 27, 2025
12 checks passed
@github-actions github-actions bot deleted the ts-go branch October 27, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant