Conversation
|
📝 WalkthroughWalkthroughThe PR updates dependencies across the monorepo to newer versions, adds a new cache path for the Vite config build output in GitHub Actions, and introduces significant changes to the CSS classname API by adding a new Changes
Possibly related PRs
Poem
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Triggered from #292 by @black7375. Checking if we can fast forward Target branch ( commit 7aa2c457f83bb006b3f4391a9ec0fcaf3ce9bb94 (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Mon Nov 24 00:00:00 2025 +0900
Feat: `cx.multiple()` for declare multiple classes #291Pull request ( commit fb4634c42ccfbdc3b82b24731c0e5d20c406c9c1 (pull_request/cx-fn)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Mon Dec 1 00:00:00 2025 +0900
chore: bumpup dependencyIt is possible to fast forward |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@configs/eslint-config-custom/package.json`:
- Around line 21-22: The upgrade to globals 17.0.0 split out the audioWorklet
environment which can break ESLint if your config implicitly relied on browser
globals; in the package.json where "@types/node" and "@typescript-eslint/parser"
are updated, verify your ESLint config (e.g., your shared config or .eslintrc)
explicitly enables the audioWorklet globals or declares them as readonly globals
(or adds the new "audioWorklet" env) instead of relying on "browser" alone, and
run lint to confirm no undefined-global errors; if you need to support older
setups, pin globals to a pre-17.x version or add explicit entries for
audioWorklet in the "globals" section of your ESLint config.
🧹 Nitpick comments (2)
packages/css/src/classname/cx.ts (2)
45-46: Consider guarding against inherited enumerable properties.The
for...inloop withouthasOwnPropertycheck will iterate inherited enumerable properties. While this is typically safe with plain object literals, it could cause unexpected behavior if the input object has a modified prototype.🔧 Optional: Use Object.keys or hasOwnProperty guard
function cxMultiple<T extends ClassMultipleInput>( map: T ): ClassMultipleResult<T> { const result = {} as ClassMultipleResult<T>; - for (const key in map) { - result[key] = cxImpl(map[key]); + for (const key of Object.keys(map) as (keyof T)[]) { + result[key] = cxImpl(map[key]); } return result; }
68-69: Same inherited property concern applies here.The
for...inloop incxWithMultiplehas the same consideration ascxMultipleregarding inherited enumerable properties.
| "@types/node": "^25.0.5", | ||
| "@typescript-eslint/parser": "^8.46.2", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
cd configs/eslint-config-custom && cat -n package.jsonRepository: mincho-js/mincho
Length of output: 1150
🌐 Web query:
@types/node 25.0.5 release notes changelog breaking changes
💡 Result:
Short answer: There are no formal release notes/changelog entries published for @types/node patch releases (including 25.0.5). Changes are tracked in the DefinitelyTyped repo (commits/PRs for types/node), and users must inspect the commit/PR history for breaking/type changes. See DefinitelyTyped and the longstanding issue asking for a changelog. [1][2]
If you want, I can fetch the types/node commit/PR list that corresponds to the 25.0.5 publish and list the exact changes and any breaking edits. Which do you prefer?
Sources:
- DefinitelyTyped repository (types/node). [1]
- Issue asking where
@types/nodechangelogs are located. [2]
🌐 Web query:
globals 17.0.0 release notes npm changelog
💡 Result:
Summary of globals v17.0.0 release (changelog / release notes)
-
Breaking
- Split audioWorklet environment out from browser. [1]
-
Improvements
- Updated globals data. [1]
- Merge browser globals from both Chrome and Firefox sources. [1]
- Added a bunBuiltin environment. [1]
Published as version 17.0.0 on the npm registry. [2]
Sources:
[1] globals v17.0.0 release notes (GitHub releases).
[2] globals package metadata on npm/jsDocs.
🌐 Web query:
prettier 3.7.4 release notes changelog breaking changes
💡 Result:
Summary — Prettier 3.7.4 (patch release)
- Type: patch (no announced breaking changes). [1][2]
- Notable fixes/changes:
- LWC: avoid adding quotes around interpolations in markup (fix for cases where Prettier previously produced foo="{bar}" → now foo={bar}). [3][4]
- TypeScript: fix duplicated comment when a comment appears inside a union type. [3]
- Miscellaneous bugfixes and small changelog edits (see package changelog/commit). [2][5]
Sources
- Prettier package listings / release metadata (v3.7.4). [1]
- Source/commit notes showing the 3.7.4 release and changelog entries. [2][5]
- Example changelog snippet showing LWC and TypeScript fixes. [3][4]
If you want, I can fetch the full CHANGELOG.md or the exact commit/PR links for each fix.
🌐 Web query:
yaml-eslint-parser 1.3.2 release notes changelog
💡 Result:
I couldn't find a dedicated "1.3.2" release entry, but sources show the package's latest published version is 1.3.2 and the repository includes a CHANGELOG.md you can check for release notes.
- Version 1.3.2 (latest) — Snyk package page. [1]
- Repository (contains CHANGELOG.md / project files) — ota-meshi/yaml-eslint-parser. [2]
If you want, I can open the repo CHANGELOG.md and extract the 1.3.2 entry for you.
Verify globals 17.0.0 breaking change doesn't affect your config.
The upgrade to globals 17.0.0 includes a breaking change: audioWorklet environment has been split out from the browser environment. If your ESLint config relies on browser globals (including audioWorklet), it will need adjustment.
Prettier 3.7.4 is a patch release with no breaking changes (TypeScript and LWC bugfixes only). @types/node and yaml-eslint-parser appear to be stable updates with no published compatibility concerns.
🤖 Prompt for AI Agents
In `@configs/eslint-config-custom/package.json` around lines 21 - 22, The upgrade
to globals 17.0.0 split out the audioWorklet environment which can break ESLint
if your config implicitly relied on browser globals; in the package.json where
"@types/node" and "@typescript-eslint/parser" are updated, verify your ESLint
config (e.g., your shared config or .eslintrc) explicitly enables the
audioWorklet globals or declares them as readonly globals (or adds the new
"audioWorklet" env) instead of relying on "browser" alone, and run lint to
confirm no undefined-global errors; if you need to support older setups, pin
globals to a pre-17.x version or add explicit entries for audioWorklet in the
"globals" section of your ESLint config.
|
/fast-forward |
|
Triggered from #292 (comment) by @black7375. Trying to fast forward Target branch ( commit 7aa2c457f83bb006b3f4391a9ec0fcaf3ce9bb94 (HEAD -> main, origin/main)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Mon Nov 24 00:00:00 2025 +0900
Feat: `cx.multiple()` for declare multiple classes #291Pull request ( commit fb4634c42ccfbdc3b82b24731c0e5d20c406c9c1 (pull_request/cx-fn)
Author: alstjr7375 <alstjr7375@daum.net>
Date: Mon Dec 1 00:00:00 2025 +0900
chore: bumpup dependencyFast forwarding $ git push origin fb4634c42ccfbdc3b82b24731c0e5d20c406c9c1:main
To https://github.com/mincho-js/mincho.git
7aa2c45..fb4634c fb4634c42ccfbdc3b82b24731c0e5d20c406c9c1 -> main |
1 participant
Description
implement
cx.withmethodRelated Issue
cx.withclassname method #290Summary by CodeRabbit
New Features
cx.with()method for typed class name composition with transformer support.Refactor
Chores
✏️ Tip: You can customize this high-level summary in your review settings.
Additional context
Checklist