Skip to content

Feat: defineRules - properties and shorcuts #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 4 commits into from
Feb 24, 2026
Merged

Feat: defineRules - properties and shorcuts #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
36a6377
Feat: defineRules type
black7375 Dec 14, 2025
59ea4f8
Feat: `defineRules` - DefineRulesComplexCssInput
black7375 Dec 25, 2025
7396e4f
Feat: `defineRules` - properties and shorcuts
black7375 Jan 28, 2026
d601036
Feat: `defineRules` - funtional properties and shortcuts
black7375 Feb 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/big-hands-rescue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@mincho-js/css": minor
---

- `defineRules`: Properties and shortcuts
5 changes: 5 additions & 0 deletions .changeset/six-coins-ask.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@mincho-js/css": minor
---

- `defineRules` - functional properties and shortcuts
1 change: 1 addition & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
"vue"
],
"cSpell.words": [
"bivariance",
"Classable",
"codegen",
"elif",
Expand Down
11 changes: 3 additions & 8 deletions examples/react-babel/tsconfig.app.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
"compilerOptions": {
"target": "ES2020",
"useDefineForClassFields": true,
"lib": [
"ES2020",
"DOM",
"DOM.Iterable"
],
"lib": ["ES2020", "DOM", "DOM.Iterable"],
"module": "ESNext",
"skipLibCheck": true,

Expand All @@ -18,6 +14,7 @@
"moduleDetection": "force",
"noEmit": true,
"jsx": "react-jsx",
"types": ["vitest/importMeta", "vite/client"],
Copy link

@coderabbitai coderabbitai bot Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check for vitest/vite dependencies across repo package.json files
fd package.json -x rg -n '"vitest"|"vite"' {}

Repository: mincho-js/mincho

Length of output: 112

🏁 Script executed:

cat -n examples/react-babel/tsconfig.app.json

Repository: mincho-js/mincho

Length of output: 1296

🏁 Script executed:

cat -n examples/react-babel/package.json 2>/dev/null || echo "No package.json in examples/react-babel"

Repository: mincho-js/mincho

Length of output: 2072

🏁 Script executed:

head -50 package.json

Repository: mincho-js/mincho

Length of output: 2750

Add vitest to devDependencies or remove vitest/importMeta from types array.

The vite/client type is available (vite is in devDependencies), but vitest/importMeta references a package not listed in examples/react-babel's dependencies. Declare vitest as a devDependency or remove the reference from the types array.

🤖 Prompt for AI Agents 
Verify each finding against the current code and only fix it if needed.

In `@examples/react-babel/tsconfig.app.json` at line 17, The tsconfig types array
includes "vitest/importMeta" but the examples/react-babel project doesn't list
vitest as a dependency; either add vitest to devDependencies in package.json (so
the "vitest/importMeta" type reference resolves) or remove "vitest/importMeta"
from the "types" array in tsconfig.app.json; locate the "types" entry and update
it accordingly to keep only installed type packages (e.g., keep "vite/client" or
add "vitest" to devDependencies).


/* Linting */
"strict": true,
Expand All @@ -36,7 +33,5 @@

"tsBuildInfoFile": "./.cache/typescript/tsbuildinfo-app"
},
"include": [
"src"
]
"include": ["src"]
}
Loading