Skip to content

Conversation

@lionelkusch
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Jul 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.08%. Comparing base (379fce6) to head (29ee470).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          22       22           
  Lines        1148     1148           
=======================================
  Hits         1126     1126           
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 184 to 186
dev/CONTRIBUTING
dev/index
generated/gallery/examples/index
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
dev/CONTRIBUTING
dev/index
generated/gallery/examples/index
generated/gallery/examples/index
dev/CONTRIBUTING
dev/index

Not 100% sure this is the place to modify it but it would be preferable if the navigation bar displays: API | examples | contributing / more (dropdown menu)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's the right place for the modification of the position of the head navigation page.

The drop menu is defined by the number of elements to show need to be modified in the configuration file.
I updated it and told me if it's what you expected.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sorry if I did not express myself clearly. The point was to have API and exemples as the two first elements.
I let you decide the number of elements before dropdown.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also suggest to add the install before the API.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The installation is on the main page.
I don't see the point to add it to the header navigator.
For going more in this direction, I was including Quick start for contributing but @bthirion seems not happy with it.

Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the result, I find that the contributors page is just a bunch of links toward other pages. I don't really like it, because it requires readers to click again and again. I'd rather have the information concentrated on few, dense pages.

@bthirion
Copy link
Collaborator

bthirion commented Jul 3, 2025

For instance, one big page for Quick start for contributing and one for another one for advanced topics.

@lionelkusch
Copy link
Collaborator Author

Looking at the result, I find that the contributors page is just a bunch of links toward other pages. I don't really like it, because it requires readers to click again and again. I'd rather have the information concentrated on few, dense pages.

What is the page "contributors page"?

For instance, one big page for Quick start for contributing and one for another one for advanced topics.

Do you want to merge Quick start for contributing and How to contribute to HiDimStat? page?

For the structure of the development documentation, I don't know what is the best way to organise the developer documentation.

@lionelkusch lionelkusch marked this pull request as ready for review July 7, 2025 09:41
Copy link
Collaborator

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ahve a bunch of minro comments. LGTM overall.

- A **summary of the expected result**.
- Any **additional details** where the bug might occur or doesn't occur unexpectedly.
- A **code snippet** that reproduces the issue, if applicable.
- **Version information** for Python, HiDimStat, and relevant dependencies (e.g., scikit-learn, numpy, pandas).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't there a simple command to get this information ? Otherwise people won't do it properly (or won't do it at all).

Copy link
Collaborator Author

@lionelkusch lionelkusch Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will depend on the package manager, but in your case, pip list should be enough.

I add a line for indicated it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can create a GitHub template for helping the user to create issues.

each file.

.. ADD THIS SECTION WHEN THERE WILL BE DOCSTRING TESTS
``` (I don't think there will be any in a near future)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want to include some tests related to the figure generated in the examples.
For it's important because the change in the figures can imply a change in the text of the examples.
I open an issue regard to it #312 .

@lionelkusch
Copy link
Collaborator Author

Looking at the result, I find that the contributors page is just a bunch of links toward other pages. I don't really like it, because it requires readers to click again and again. I'd rather have the information concentrated on few, dense pages.

What is the page "contributors page"?

For instance, one big page for Quick start for contributing and one for another one for advanced topics.

Do you want to merge Quick start for contributing and How to contribute to HiDimStat? page?

For the structure of the development documentation, I don't know what is the best way to organise the developer documentation.

@jpaillard @bthirion
Do you have a suggestion for organising the documentation for the developers?

From my side, I don't like to have a unique page but if you tell me that it is best, I do it.

@bthirion
Copy link
Collaborator

The current solution where the Quick start in one page and the how to contribute is a menu, is fine.
I think that the dev doc is not the priority for now. The narrative doc is much more important. In all packages I know the dev doc was written way after the narrative doc.

@lionelkusch
Copy link
Collaborator Author

I agree that the narrative documentation is more important. For your other packages, I think that the library was developed by the users of it, in case it's more natural to define create the narrative documentation at first . In my case, I don't use it and mainly develop it; it's more natural for me to create the developer’s documentation at first.

As I mentioned in issue #306, it's really difficult for me to create this type of documentation. I will need a real practical case for starting it. The only solution that I find for the moment is to organise a workshop on this topic.

@bthirion
Copy link
Collaborator

As I mentioned in issue #306, it's really difficult for me to create this type of documentation. I will need a real practical case for starting it. The only solution that I find for the moment is to organise a workshop on this topic.

Yes, that's the right way to proceed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants