-
Notifications
You must be signed in to change notification settings - Fork 12
D0CRT Accept Scikit-learn models directly instead of parameter dictionaries
#370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jpaillard
merged 45 commits into
main
from
369-d0crt-accept-scikit-learn-models-directly-instead-of-parameter-dictionaries
Sep 12, 2025
Merged
Changes from 12 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
70463d5
[skip doc] remove dict and add tests
jpaillard 14352f1
[skip doc] remove useless lines
jpaillard f68b292
adapt examples
jpaillard 8677b5f
[build doc] improve doc explamation
jpaillard feb5a4b
add test for error
jpaillard 255f14a
try to cover missing line
jpaillard c4c3af6
move screening out of the class so that it can be re-used
jpaillard 946217c
set to 0 non selected coef
jpaillard de0c4cf
set coef to 0 in classification
jpaillard 58afd82
fix docstring
jpaillard bb961a8
a decision_function to the list of prediction methods
jpaillard d9aee7c
add transform to the list
jpaillard 1df0c82
remove transform
jpaillard 8f7c50d
remove sentence on d1CRT
jpaillard abb1cfb
fix regression typo
jpaillard 582fd3f
add line
jpaillard 51a0522
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard b700347
Update test/test_distilled_conditional_randomization_test.py
jpaillard 5aad988
Update test/test_distilled_conditional_randomization_test.py
jpaillard 07239b0
Update test/test_distilled_conditional_randomization_test.py
jpaillard d7206c7
fix all typos
jpaillard 8cb08cb
set default random_state to None
jpaillard fe27364
Merge branch 'main' of github.com:mind-inria/hidimstat into 369-d0crt…
jpaillard 02c1eb6
formatting
jpaillard 6c5d3ab
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard 462153d
underscore after selection_set
jpaillard 4e215e4
fix test
jpaillard 9f663b3
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard 4373310
remove is_lasso att
jpaillard 8acbfa1
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard b34546e
Merge branch '369-d0crt-accept-scikit-learn-models-directly-instead-o…
jpaillard d706870
set underscore attributes to None in init, update check_fit
jpaillard 43cb619
remove coefficient from check_fit
jpaillard 92829ad
Merge branch 'main' into 369-d0crt-accept-scikit-learn-models-directl…
lionelkusch 947fe83
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard e6cb9d1
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard 19dd850
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard 06d79b3
format
jpaillard d386573
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard 2a1d53c
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard c2ccac3
Update src/hidimstat/distilled_conditional_randomization_test.py
jpaillard c3f9f01
remove lasso_model_ from attributes
jpaillard 056a0d3
Merge branch '369-d0crt-accept-scikit-learn-models-directly-instead-o…
jpaillard 469470b
add docstring
jpaillard 32b7b8d
Merge branch 'main' into 369-d0crt-accept-scikit-learn-models-directl…
lionelkusch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we provide no implementation of d1CRT, we should not make any claim on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the last sentence