-
Notifications
You must be signed in to change notification settings - Fork 12
Add folder description #489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 23 23
Lines 1253 1253
=======================================
Hits 1244 1244
Misses 9 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jpaillard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the description of folder organisation is not so clear.
For most files, the content is quite explicit based on the name and position in the hierarchy.
However, for some folders, the description is not detailed enough. It would be clarified by answering, for example (not exhaustive list): What goes in statistical tools? What is the difference between statistical_tools and _utils? Why is _utils private? Why is multiple_testing not in /src?
bthirion
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for opening. A few details can be fixed.
How do we ensure that this remains accurate across time ?
Co-authored-by: bthirion <[email protected]>
Co-authored-by: bthirion <[email protected]>
Co-authored-by: bthirion <[email protected]>
Co-authored-by: bthirion <[email protected]>
Co-authored-by: bthirion <[email protected]>
Co-authored-by: bthirion <[email protected]>
Co-authored-by: bthirion <[email protected]>
I tried to select the file, which will be staying for a long time and won't change name. |
I propose to have the discussion in #86 for the moment for having track of the history of the previous conversation. |
|
Could you just add a few lines explaining the rationale behind the decision of placing some modules in statistical_tools in #366? |
|
Mainly in src/hidimstat, there should be only Conditional feature importance methods. |
No description provided.