Skip to content
This repository was archived by the owner on May 14, 2025. It is now read-only.

fix token name #85

Merged
hamishfagg merged 1 commit into from
May 6, 2025
Merged

fix token name #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/mindsdb_datasources.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
- name: Build and publish
env:
TWINE_USERNAME: __token__
TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
Copy link

@entelligence-ai-pr-reviews entelligence-ai-pr-reviews bot May 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correctness: The GitHub Actions workflow is referencing secrets.PYPI_PASSWORD instead of secrets.PYPI_TOKEN, which may cause authentication failures when publishing to PyPI if the secret is incorrectly named in the repository settings.

📝 Committable Code Suggestion

‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
TWINE_PASSWORD: ${{ secrets.PYPI_PASSWORD }}
TWINE_PASSWORD: ${{ secrets.PYPI_TOKEN }}

run: |
python setup.py sdist
twine upload dist/*
Loading