Skip to content

Commit bf613d4

Browse files
authored
Merge pull request #10 from mindsdb/del-ds
Remove datasource
2 parents 12ecdc9 + 2549896 commit bf613d4

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

examples/base_usage.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,6 @@
6363
mind = client.minds.get('mind_name')
6464

6565
# removing datasource
66-
# ? should it drop datasource if it is not connected to any mind anymore?
67-
# TODO is not implemented on gateway
6866
mind.del_datasource(datasource)
6967

7068
# remove mind

minds/minds.py

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,16 @@ def add_datasource(self, datasource: Datasource):
8282
self.datasources = updated.datasources
8383

8484
def del_datasource(self, datasource: Union[Datasource, str]):
85-
raise NotImplementedError
85+
if isinstance(datasource, Datasource):
86+
datasource = datasource.name
87+
elif not isinstance(datasource, str):
88+
raise ValueError(f'Unknown type of datasource: {datasource}')
89+
self.api.delete(
90+
f'/projects/{self.project}/minds/{self.name}/datasources/{datasource}',
91+
)
92+
updated = self.client.minds.get(self.name)
93+
94+
self.datasources = updated.datasources
8695

8796
def completion(self, message: str, stream: bool = False) -> Union[str, Iterable[object]]:
8897
"""

0 commit comments

Comments
 (0)