docs(ollama): standardize engine usage to 'ollama' to resolve confusion #12029
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All contributors have signed the CLA ✍️ ✅ |
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
Comment on lines
63
to
69
| CREATE MODEL llama3_model | ||
| PREDICT completion | ||
| USING | ||
| engine = 'ollama_engine', | ||
| engine = 'ollama', | ||
| model_name = 'llama3'; | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Correctness: Change 'engine' to 'ollama' to match the correct engine name and avoid runtime errors.
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
kelvinvelasquez-SDE
force-pushed
the
fix/ollama-docs
branch
from
5da2fe1 to
19c7b10
Compare
Author
|
recheck |
Contributor
|
Thanks @kelvinvelasquez-SDE The working behavior does not expect |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12011
Description
This PR addresses user confusion regarding the
ollamaintegration documentation. Users reported that the examples usingollama_enginewere inconsistent with the working behavior which expectsollama.Changes
docs/integrations/ai-engines/ollama.mdxto useollamaas the engine name inCREATE ML_ENGINEandUSINGclauses.mindsdb/integrations/handlers/ollama_handler/README.mdto match the documentation and ensure consistency.Verification