Skip to content

Add a feat to auto sign off the commit if the environment is provided. #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 30, 2025
Merged

Add a feat to auto sign off the commit if the environment is provided. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
81f8d94
fix: update artifact attestation in CI workflow 📝
mingcheng Mar 5, 2025
91c75e4
docs: enhance Docker usage instructions in README 📚
mingcheng Mar 5, 2025
32f2366
refactor: update template instructions for commit messages 📝
mingcheng Mar 5, 2025
e4e6c8b
feat: implement signoff feature for commit messages ✍️
mingcheng Mar 5, 2025
bb3242c
feat: add auto signoff detection from environment variable ✍️
mingcheng Mar 5, 2025
1064376
docs: update README with new environment variable for signoff 📚
mingcheng Jun 30, 2025
b4b8f58
chore(deps): bump tokio from 1.44.1 to 1.44.2
dependabot[bot] Apr 8, 2025
977880d
chore(deps): bump openssl from 0.10.71 to 0.10.72
dependabot[bot] Apr 4, 2025
66f63e5
style: update log message formatting in git and openai modules 🖌️ (#13)
mingcheng Jun 30, 2025
bad3eab
docs: correct environment variable name in README 📚
mingcheng Jun 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/ghcr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,9 @@ jobs:
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:latest
${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ steps.short-sha.outputs.sha }}
labels: ${{ steps.meta.outputs.labels }}
# - name: Generate artifact attestation
# uses: actions/attest-build-provenance@v2
# with:
# subject-name: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
# subject-digest: ${{ steps.push.outputs.digest }}
# push-to-registry: true
- name: Generate artifact attestation
uses: actions/attest-build-provenance@v2
with:
subject-name: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
subject-digest: ${{ steps.push.outputs.digest }}
push-to-registry: false
Comment on lines +51 to +56
Copy link

@coderabbitai coderabbitai bot Jun 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Attestation step will fail on pull_request events – add a guard

docker/build-push-action does not populate steps.push.outputs.digest when push: false (which is the case for pull-requests).
Because the attestation step runs unconditionally, it receives an empty digest and the action errors out.

       - name: Generate artifact attestation
+        # Only run when an image has actually been pushed
+        if: ${{ github.event_name != 'pull_request' }}
         uses: actions/attest-build-provenance@v2

This keeps the workflow green for PRs while still producing provenance for main/tag pushes.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Generate artifact attestation
uses: actions/attest-build-provenance@v2
with:
subject-name: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
subject-digest: ${{ steps.push.outputs.digest }}
push-to-registry: false
- name: Generate artifact attestation
# Only run when an image has actually been pushed
if: ${{ github.event_name != 'pull_request' }}
uses: actions/attest-build-provenance@v2
with:
subject-name: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}
subject-digest: ${{ steps.push.outputs.digest }}
push-to-registry: false
🤖 Prompt for AI Agents 
In .github/workflows/ghcr.yml around lines 51 to 56, the attestation step runs
unconditionally and fails on pull_request events because
steps.push.outputs.digest is empty when push is false. Fix this by adding a
conditional guard to the attestation step so it only runs when the digest output
is available, typically by checking if the event is not a pull_request or if the
digest exists, preventing errors and keeping the workflow green for PRs.

Loading