Introduce mypy for static analysis and fix some bugs that mypy revelaed#960
Open
vadim2404 wants to merge 3 commits intomingrammer:masterfrom
Open
Introduce mypy for static analysis and fix some bugs that mypy revelaed#960vadim2404 wants to merge 3 commits intomingrammer:masterfrom
mypy for static analysis and fix some bugs that mypy revelaed#960vadim2404 wants to merge 3 commits intomingrammer:masterfrom
Conversation
breakid
approved these changes
Sep 27, 2024
breakid
left a comment
There was a problem hiding this comment.
I've reviewed all of the code changes, and everything looks good to me. The changes are mostly adding type hints, plus some minor optimizations such as using f-strings and converting some elif blocks to guard statements, which are a bit cleaner.
The only logic change I saw was the following from the append() method in the Edge class, which appears to be a bug fix, but which I wanted to highlight in case someone more familiar with the code base knows of any unintended side effects this might cause.
o.reverse = forward if forward else o.reverse -> o.reverse = reverse if reverse else o.reverse
I'm looking forward to these changes being merged!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea is to add static code analysis for the code to catch bugs earlier and help engineers with type hinting in the IDEs they use.