Skip to content

Conversation

@michelebastione
Copy link
Contributor

Tests

  • Removed superfluous packages (FluentAssertions, ClosedXml.Report, NSubstitute) and updated remaining packages
  • Optimized import sattements
  • Synced namespaces to MiniExcelLibs.Tests and changed block scopes to file scopes
  • Extensive use of collection expresions and using statements
  • Changed Console.WriteLine calls to ITestOutputHelper.WriteLine
  • Added AutoDeletingPath helper class to avoid having to manually delete temp files at the end of every method
  • General code cleanup and styling for simplicity and readability

Benchmarks

  • Updated packages and target frameworks to have a more modern and realistic comparison with other libraries
  • Added AutoDeletingPath helper class to avoid having to manually delete temp files at the end of every method
  • Changed Program.cs file to top level statement syntax
  • Code cleanup

Other

  • Minor change to template regex
  • Made some exception messages clearer
  • General code cleanup

Updating packages, added helper class to automatically delete temp files, refactoring and code cleanup
Removed superfluous packages and updated the required ones. Synced namespaces to MiniExcelLibs.Test and added AutoDeletingPath helper class to avoid having to manually delete all temp files at the end of a test run. General clean up and implementation of good practices for improved readability.
@michelebastione
Copy link
Contributor Author

I know this is a lot of code changes but most of it is just about styling and formatting

@shps951023
Copy link
Member

❤❤ I had an issue before : because I don't know how to get maximum memory usage (not total memory usage) by dotnet benchmark. so the issue not finished yet.

@shps951023 shps951023 merged commit 3718c64 into mini-software:master Apr 11, 2025
3 checks passed
@michelebastione
Copy link
Contributor Author

I'm afraid that's not going to be possible with benchmarkdotnet, that information is not registered anywhere.

@michelebastione michelebastione deleted the refactoring branch April 11, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants