refactor: auto-generate sync methods #807
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
virzak
reviewed
Jun 17, 2025
Contributor
|
This is great! There's also the opportunity to eliminate CsvWriter.WriteValues. It diverged from WriteValuesAsync and I haven't had a chance to converge them. |
Member
Author
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary SYNC_ONLY definitions and delete some synchronous methods or classes, switching to auto-generation instead.
It would be even better if the sync-method-generator could support applying the attribute to an entire class for conversion. I've created a Feature Request for them.