-
-
Notifications
You must be signed in to change notification settings - Fork 401
Big refactoring before first beta release #821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
michelebastione
merged 6 commits into
mini-software:master
from
michelebastione:big_refactoring
Jun 23, 2025
Merged
Big refactoring before first beta release #821
michelebastione
merged 6 commits into
mini-software:master
from
michelebastione:big_refactoring
Jun 23, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Bumped language version to 13 - Added suuport for nullable reference types - Changed block scoped namespaces to file scoped - Changed MiniExcelLibs.OpenXml.SaveByTemplate to MiniExcelLibs.SaveByTemplate - Changed using statements to using declarations where possible and appropriate - Implemented collections expressions where possible and appropriate - Chanegd == null and != null checks to is null and is not null - Implemented pattern matching and primary constructors where possible and appropriate - Removed License code file - Added the TaskHelper class - Renamed OpenXml.Config class to OpenXml.Constants.Schemas - Renamed IConfiguration and Configuration classes to IMiniExcelConfiguration and MiniExcelConfiguration - Renamed calChainHelper.cs file to CalcChainHelper.cs - Minor style changes (sorting modifiers, renaming variables, etc...)
* v1.41.2 AddPicture not working mini-software#814 * mini-software#814 samples * Fix v1.41.1 AddPicture image max column and row are 2 cells mini-software#815 * Fix AddPicture get error same export file and second time. mini-software#817 --------- Signed-off-by: Wei Lin <[email protected]> (cherry picked from commit 1103aed)
- Fixes issues 814, 815 and 817 - Upgrades ClosedXml and Epplus packages in test project - Adds EpplusLicense class that specifies the context as non commercial - Resolves conflicting targetframeworks in main csproj and bumps version to 2.0.0-beta.1 - Addds codeql analysis to pushes and prs of maintenance branch - Fixes typo in drawio diagram Co-Authored-By: Wei Lin <[email protected]>
Contributor
Author
|
On further thought, separating the assemblies will be a big enough endeavour on its own, so it's probably for the best if we take our time with it. |
Member
izanhzh
requested changes
Jun 23, 2025
izanhzh
approved these changes
Jun 23, 2025
shps951023
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Given our decision to move forwards with a v2 release, I tought this was a good moment to implement a number of changes to the codebase, some long overdue:
2.0.0-beta.113to make use of new syntax featuresMiniExcelLibs.OpenXml.SaveByTemplatetoMiniExcelLibs.SaveByTemplate== nulland!= nullchecks tois nullandis not nullOpenXml.Configclass toOpenXml.Constants.SchemasIConfigurationandConfigurationclasses toIMiniExcelConfigurationandMiniExcelConfigurationcalChainHelper.csfile toCalcChainHelper.csTargetFrameworksin main project fileClosedXmlandEppluspackages in test projectEpplusLicenseclass that specifies the context as non commercialMiniExcelTask.cs, it was only included for compatibility with .net45I would also like to separate everything in 3 main assemblies:
MiniExcelLibs.Core,MiniExcelLibs.OpenXmlandMiniExcelLibs.Csv. I'm not sure yet if it's approprate to add this other big change here or to make a subsequent PR.Let me know what you guys think about it all.