Skip to content

Add postgis extension for postgresql and it's dependencies#1400

Merged
yselkowitz merged 2 commits intominimization:mainfrom
ljavorsk:main
Apr 15, 2025
Merged

Add postgis extension for postgresql and it's dependencies#1400
yselkowitz merged 2 commits intominimization:mainfrom
ljavorsk:main

Conversation

@ljavorsk
Copy link
Contributor

Resolves: RHELPLAN-171698 RHELPLAN-171818 RHELPLAN-171821 RHELPLAN-171697

@ljavorsk ljavorsk force-pushed the main branch 2 times, most recently from a90b210 to e80eef1 Compare March 26, 2025 10:17
@yselkowitz yselkowitz self-assigned this Mar 26, 2025
Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Some of these components are going to require changes first in (RHEL and) ELN in order to avoid unwanted dependencies, so this can't be merged quite yet, but you may proceed with the PRP in the meantime.

  • proj has some deprecated() subpackages which presumably should be disabled for RHEL and ELN. It's mingw subpackages would already be disabled.
  • geos should have its mingw subpackages disabled when built for RHEL; if wanted in EPEL, then the separate mingw-geos package should be revived instead.
  • gdal has a LOT of additional dependencies in Fedora. Some of those may ultimately be optional, but will need to be conditionalized.
  • postgis in Fedora also has a dependency on SFCGAL, will that be disabled in RHEL?
  • Will the postgis SRPM be renamed to e.g. postgresql16-postgis like other postgresql-related components to allow future versions per the latest naming scheme?

@fila43
Copy link
Contributor

fila43 commented Mar 27, 2025

Hi @yselkowitz,
I hope we have already addressed all of your comments in Fedora's PRs. Any kind of review is welcome.

Yes, we plan to use the versioned name for Postgis, as we already do for the other postgresql extensions. Here, I am not sure how to approach content resolver because in Fedora, there is going to be a postgis component, but in RHEL, there will be postgresql16-postgis. Is such a difference acceptable?

@yselkowitz
Copy link
Collaborator

Thanks for the PRs, I'm following those now.

As for postgis vs. postgresql16-postgis, since the difference is only in the SRPM name while CR tracks RPMs, it's okay for now, but it will make things difficult when we start preparing c11s. Therefore, while you should focus on getting these ready for RHEL 10 and ELN through the PRs and PRP etc., once everything is set, then we'll need to look at renaming the package in Fedora to match the new naming scheme.

@fila43
Copy link
Contributor

fila43 commented Apr 2, 2025

@yselkowitz So, can we merge this PR for now?

@yselkowitz
Copy link
Collaborator

No, because merging this would cause those packages to be added to ELN, and in their current state, that would add a bunch of unwanted dependencies to ELN. You may proceed with the RHEL PRP in the meantime.

@fila43
Copy link
Contributor

fila43 commented Apr 3, 2025

Ok, I will ping you once the MRs in Fedora are done.

@fila43
Copy link
Contributor

fila43 commented Apr 8, 2025

@yselkowitz We have discussed a renaming scheme for PostGIS in my team. Nowadays, all renamed components must be recreated in Fedora for every single Postgresql version. It consumes our capacity and the profit for Fedora is questionable. What is your opinion on keeping it as it is without the version? It would continue as a rolling stream in Fedora, and once c11s comes, we will rename it there.

Copy link
Collaborator

@yselkowitz yselkowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The packaging changes have all landed in rawhide and ELN.

The SRPM name doesn't need to be fixed today, but it should be fixed eventually not only for consistency with the rest of Fedora, and because it will affect the import of RHEL 11. It looks like postgresql17 packages are on their way, that would provide a good opportunity to get this on the same naming scheme as the rest of the packages.

Resolves: RHELPLAN-171818 RHELPLAN-171821 RHELPLAN-171697
Resolves: RHELPLAN-171698
@yselkowitz yselkowitz merged commit ea68f66 into minimization:main Apr 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants