Implement support for new UpdateObjectEncryption API & bump Go to 1.25#2204
Open
rraulinio wants to merge 13 commits intominio:masterfrom
Open
Implement support for new UpdateObjectEncryption API & bump Go to 1.25#2204rraulinio wants to merge 13 commits intominio:masterfrom
rraulinio wants to merge 13 commits intominio:masterfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Go SDK support for a new UpdateObjectEncryption operation by introducing a dedicated client API and accompanying unit tests.
Changes:
- Introduce
Client.UpdateObjectEncryptionwith request XML marshaling and request execution logic. - Add unit tests covering XML roundtrip, success path, optional versionId behavior, and error handling.
- Update repo metadata (
go.modGo version,.gitignorevendor ignore).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| go.mod | Bumps the module go version directive. |
| api-update-object-encryption.go | Adds the UpdateObjectEncryption API implementation and request/option types. |
| api-update-object-encryption_test.go | Adds unit tests for request XML and HTTP behavior. |
| .gitignore | Ignores vendor/ directory. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rraulinio
changed the title
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Added a few small changes for some workflows also, getting them up to date. |
klauspost
requested changes
Feb 19, 2026
rraulinio
changed the title
rraulinio
requested review from
harshavardhana
and removed request for
harshavardhana
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement support for new
UpdateObjectEncryptionAPI in relation to the CLI.Ref: https://docs.aws.amazon.com/AmazonS3/latest/API/API_UpdateObjectEncryption.html