xml-parser.parseResponseError(): return parsed error instead of throwing#1401
Open
alxndrsn wants to merge 1 commit intominio:masterfrom
Open
xml-parser.parseResponseError(): return parsed error instead of throwing#1401alxndrsn wants to merge 1 commit intominio:masterfrom
alxndrsn wants to merge 1 commit intominio:masterfrom
Conversation
Member
|
could you please fix the lint errors @alxndrsn ? |
Contributor
Author
Sure. How would you recommend resolving the type errors? Should errors in |
Member
|
not sure, i have not found a strongly typed type for this , but we can improve progressively |
Contributor
Author
|
Should I just add |
Member
|
you could explore casting, composite type etc @alxndrsn |
Contributor
Author
👍 Do you think errors in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1400