Skip to content

fix(compose): resolve infinite recursion in ComposeSource properties #1524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −4
Open

fix(compose): resolve infinite recursion in ComposeSource properties #1524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions minio/commonconfig.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,22 +466,22 @@ def build_headers(self, object_size: int, etag: str):
@property
def object_size(self) -> Optional[int]:
"""Get object size."""
if self.object_size is None:
if self._object_size is None:
raise MinioException(
"build_headers() must be called prior to "
"this method invocation",
)
return self.object_size
return self._object_size

@property
def headers(self) -> dict[str, str]:
"""Get headers."""
if self.headers is None:
if self._headers is None:
raise MinioException(
"build_headers() must be called prior to "
"this method invocation",
)
return self.headers.copy()
return self._headers.copy()

@classmethod
def of(cls: Type[F], src: ObjectConditionalReadArgs) -> F:
Expand Down